ci: cache submodules#1081
Conversation
A build can be forced with a label `force-build`.
WalkthroughThe GitHub Actions build workflow was updated to limit the Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build.yaml (1)
30-33: Conditional to skip draft PR builds is correct
Theifexpression cleanly skips builds for draft PRs (unless labeledforce-build) while still running on other events. Consider adding an inline comment for clarity, as this logic can be non-intuitive.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
.github/workflows/build.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build plugin and addons
🔇 Additional comments (2)
.github/workflows/build.yaml (2)
53-53: Good addition of submodule and extern caching
Including.gitmodulesandextern/**in the cache key ensures cache invalidation when submodules or external dependencies change. This aligns with the PR goal to cache submodules.
13-23:⚠️ Potential issueEnsure file path globs match all relevant files
The current patterns use**.cpp,**.h, etc., which may not match files in subdirectories (e.g.,src/foo.cpp). For consistency—and to mirror the patterns in the cache key—use**/*.cpp,**/*.h,**/*.hpp,**/*.c, and**/CMakeLists.txt.Apply this diff:
pull_request_target: - paths: - - '**.cpp' - - '**.h' - - '**.hpp' - - '**.c' - - 'CMakeLists.txt' + paths: + - '**/*.cpp' + - '**/*.h' + - '**/*.hpp' + - '**/*.c' + - '**/CMakeLists.txt' - 'CMakePresets.json' - 'vcpkg.json' - 'vcpkg-configuration.json' - '.gitmodules' - 'extern/**'Likely an incorrect or invalid review comment.
|
✅ A pre-release build is available for this PR: |
Summary by CodeRabbit