Skip to content

chore(sss): optimise final pass #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 2 commits into from
Mar 9, 2025
Merged

chore(sss): optimise final pass #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cd74e0
chore(sss): optimise final pass
doodlum Mar 9, 2025
919d079
style: 🎨 apply clang-format changes
doodlum Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/Subsurface Scattering/Shaders/Features/SubsurfaceScattering.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[Info]
Version = 2-0-0
Version = 2-0-1
2 changes: 1 addition & 1 deletion features/Subsurface Scattering/Shaders/SubsurfaceScattering/SeparableSSS.hlsli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ float4 SSSSBlurCS(
float3 color = ColorTexture[coords].rgb;

#if defined(HORIZONTAL)
color.rgb = Color::GammaToLinear(color.rgb);
color.rgb = Color::GammaToTrueLinear(color.rgb);
#endif

float depth = DepthTexture[coords].r;
Expand Down
11 changes: 7 additions & 4 deletions features/Subsurface Scattering/Shaders/SubsurfaceScattering/SeparableSSSCS.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,14 @@ cbuffer PerFrameSSS : register(b1)
#else

float sssAmount = MaskTexture[DTid.xy].x;
bool humanProfile = MaskTexture[DTid.xy].y == sssAmount;

float4 color = SSSSBlurCS(DTid.xy, texCoord, float2(0.0, 1.0), sssAmount, humanProfile);
color.rgb = Color::TrueLinearToGamma(color.rgb);
SSSRW[DTid.xy] = float4(color.rgb, 1.0);
if (sssAmount > 0.0) {
bool humanProfile = MaskTexture[DTid.xy].y == sssAmount;

float4 color = SSSSBlurCS(DTid.xy, texCoord, float2(0.0, 1.0), sssAmount, humanProfile);
color.rgb = Color::TrueLinearToGamma(color.rgb);
SSSRW[DTid.xy] = float4(color.rgb, 1.0);
}

#endif
}