WARC writer support HTTP/2 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds property store.protocol.versions - if true, protocol-okhttp records protocol versions and related in response metadata.
Activate HTTPHeadersInterceptor also if only store.protocol.versions is true, but no other headers and connection information is intercepted.
In combination with NUTCH-3062, if store.protocol.versions is true: adds two counters "HttpProtocolVersion" and "TlsProtocolVersion" counting the values stored by protocol-okhttp in the protocol versions field of content metadata. Counted values are the protocol versions.
- HTTP headers: replace HTTP/2 and alike by HTTP/1.1 to ensure backward-compatibility for WARC readers, see iipc/warc-specifications#15 - store protocol versions and cipher suites in WARC headers WARC-Protocol and WARC-Cipher-Suite, see iipc/warc-specifications#42 iipc/warc-specifications#86 - allow multiple WARC headers of the same name (WARC-Protocol may occur twice to hold the HTTP and TLS version)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(implements #29, includes NUTCH-3062)
WARC-Protocoland `WARC-Cipher-Suite, seeWARC-Protocol field proposal iipc/warc-specifications#42 and WARC-Cipher-Suite field proposal iipc/warc-specifications#86
WARC-Protocolmay occur twice to hold the HTTP and TLS version)