Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prov data input output #1989

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

Prov data input output #1989

wants to merge 42 commits into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 62.37624% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (55ccde7) to head (743ac15).

Files with missing lines Patch % Lines
cwltool/cwlprov/ro.py 43.18% 20 Missing and 5 partials ⚠️
cwltool/cwlprov/__init__.py 53.84% 6 Missing ⚠️
cwltool/cwlprov/provenance_profile.py 40.00% 6 Missing ⚠️
cwltool/cwlprov/writablebagfile.py 75.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (55ccde7) and HEAD (743ac15). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (55ccde7) HEAD (743ac15)
17 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1989       +/-   ##
===========================================
- Coverage   83.80%   70.18%   -13.63%     
===========================================
  Files          46       46               
  Lines        8270     8328       +58     
  Branches     2202     2117       -85     
===========================================
- Hits         6931     5845     -1086     
- Misses        858     1864     +1006     
- Partials      481      619      +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjkoehorst
Copy link
Contributor

@mr-c I think I fixed the code make cleanup could you have a look at the other tests? Not sure if they fail due to this implementation.

tests/test_provenance.py Outdated Show resolved Hide resolved
@ElderMedic
Copy link
Collaborator

@mr-c Hey! Would you review the --no-data --no-input implementation and give us some feedback if possible? Thanks! @

@mr-c
Copy link
Member Author

mr-c commented Jul 24, 2024

Hey @ElderMedic ! I just started a vacation. I'll be back next week. Feel free to ping me again if you don't hear from me in 2 weeks.

Sync Updates to prov_data_input_output branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants