-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append "cwltool" to HTTP User-Agent string #1977
Append "cwltool" to HTTP User-Agent string #1977
Conversation
Thanks for your PR @svonworl . There are several other CWL runners that reuse this code. Would you prefer they use their own program name, or should we stick to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 46 46
Lines 8235 8245 +10
Branches 2187 2190 +3
=======================================
+ Hits 6901 6910 +9
Misses 858 858
- Partials 476 477 +1 ☔ View full report in Codecov by Sentry. |
Hi @mr-c, it'd be great if |
4634f25
to
1346470
Compare
…rl/cwltool into add-cwltool-to-user-agent
Head branch was pushed to by a user without write access
Looks like one of the checks failed, could it be a test flake? I can't see anything in the PR that would've broken it... |
Should work for calrissian, reana-cwl-runner, and arvados-cwl-runner, but not toil-cwl-runner which doesn't call the cwltool.main.main() function. Probably works for streamflow, but I haven't tested that.
Hi, my name is Steve, and I'm an engineer on the Dockstore team. This PR appends the string "cwltool" to the
User-Agent
string of all cwltool HTTP requests issued via therequests
package, so it looks like:This PR would allow us to differentiate cwltool traffic from other Dockstore traffic that originates from the
requests
package. After this change, we'd be able to track cwltool usage and handle its requests more appropriately. For example, it'd be more feasible for us to filter a DOS attack and not affect cwltool traffic, or to tweak our webservice with a cwltool-specific accommodation.