Port prior components as stories #60
Conversation
|
I guess we should put them in this release as stories and maybe do a vote on how to proceed. I think some are good candidates for components; my concern is more about them getting too large to really be considered components. I think things like Login is at the limit. Login itself is particular awkward as it is so common it probably merits being a component but anything else that size/complex wouldn't. I'll put this on top of my changes and get it released. |
|
(Should have probably made the PR to my branch, but not to worry now) |
This reverts commit 774473e.
|
Just looking at the images - I think the confirm dialog should have the Confirm should be on the right n(https://uxmovement.com/buttons/why-ok-buttons-in-dialog-boxes-work-best-on-the-right/) and the other button, would be better in the text variant. |
stories/components/describedselector/describedselector.stories.mdx
Outdated
Show resolved
Hide resolved
stuarthendren
force-pushed
the
sh-develop
branch
from
ada6a85
to
7c56ecb
Compare
Reworks the Theme provider to be clearer about the functionality. Minor improvements elsewhere with more components and support functions re-exported from material, including the labs components.
stuarthendren
force-pushed
the
je-components
branch
from
fb8ff5b
to
02a1b41
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
The first batch of components from #50
These are just stories at the moment. @stuarthendren what are your thoughts on adding in as proper components?
DescribedSelector
ConfirmDialog
PageHeading
ErrorMessage
ErrorBoundary
EmptyState
