fix: stop forced layout what data added or resized

This can be done in used sitiations by invalidating the layout, so here should not be forced
commitd · Dec 23, 2022 · 72516cc · 72516cc
1 parent 082496c
commit 72516cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/packages/react/src/graph/renderer/CytoscapeRenderer.test.tsx b/packages/react/src/graph/renderer/CytoscapeRenderer.test.tsx
@@ -57,11 +57,11 @@ it('can be rendered', () => {
     />
   )
   expect(asFragment()).toBeDefined()
-  expect(cytoscape.addListener).toHaveBeenCalledTimes(10)
+  expect(cytoscape.addListener).toHaveBeenCalledTimes(8)
 
   unmount()
 
-  expect(cytoscape.removeListener).toHaveBeenCalledTimes(10)
+  expect(cytoscape.removeListener).toHaveBeenCalledTimes(8)
 })
 
 it('layout command triggers layout', () => {

diff --git a/packages/react/src/graph/renderer/CytoscapeRenderer.tsx b/packages/react/src/graph/renderer/CytoscapeRenderer.tsx
@@ -239,9 +239,6 @@ const Renderer: GraphRenderer<CyGraphRendererOptions>['render'] = ({
     [onViewNode, graphModel]
   )
 
-  const updateLayout = useCallback(() => {
-    triggerLayout(layout)
-  }, [triggerLayout, layout])
   const selectNode = useCallback(
     (e: EventObject) => {
       const selectedNodes = e.target as NodeCollection
@@ -280,8 +277,6 @@ const Renderer: GraphRenderer<CyGraphRendererOptions>['render'] = ({
     }
   }, [])
 
-  useCyListener(cytoscape, updateLayout, 'add remove', 'edge')
-  useCyListener(cytoscape, updateLayout, 'resize', 'edge')
   useCyListener(cytoscape, selectNode, 'select', 'node')
   useCyListener(cytoscape, unselectNode, 'unselect', 'node')
   useCyListener(cytoscape, selectEdge, 'select', 'edge')