Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silero-vad #7633

Closed
wants to merge 1 commit into from
Closed

Add silero-vad #7633

wants to merge 1 commit into from

Conversation

qwbarch
Copy link
Contributor

@qwbarch qwbarch commented Dec 26, 2024

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@qwbarch
Copy link
Contributor Author

qwbarch commented Dec 26, 2024

Sorry, I wasn't able to run the verify-package script since I don't have WSL installed at the moment.
I'll try to fix the build soon. Quick question though, the stackage CI failed due to my executable/test depending on WAVE, which is not on stackage.
Could I possibly just have the executable/test disabled for stackage?

@mihaimaruseac
Copy link
Contributor

Unfortunately we cannot skip main library and executables. You can add WAVE to stackage too, though, if you want to maintain it on stackage side (i.e., respond to bound issues)

@qwbarch
Copy link
Contributor Author

qwbarch commented Dec 26, 2024

Thanks for the quick response! I think I'll just close this then, until I switch my dependency on the main executable

@qwbarch qwbarch closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants