Inhibit errors from terminal-size

ChangeLog.md

@@ -19,6 +19,9 @@ Other enhancements:
 
 Bug fixes:
 
+* Errors from the `terminal-size` package are now silenced. See
+  [#4901](https://github.com/commercialhaskell/stack/issues/4901)
+
 
 ## v2.1.3.1
 

package.yaml

@@ -108,6 +108,7 @@ dependencies:
 - rio
 - rio-prettyprint
 - semigroups
+- silently
 - split
 - stm
 - streaming-commons

src/Stack/Runners.hs

@@ -36,6 +36,8 @@ import           Stack.Types.Nix (nixEnable)
 import           Stack.Types.Version (stackMinorVersion, stackVersion, minorVersion)
 import           System.Console.ANSI (hSupportsANSIWithoutEmulation)
 import           System.Console.Terminal.Size (size, width)
+import           System.IO.Silently (hSilence)
+import           System.IO (stderr)
 
 -- | Ensure that no project settings are used when running 'withConfig'.
 withGlobalProject :: RIO Runner a -> RIO Runner a
@@ -145,8 +147,10 @@ withRunnerGlobal go inner = do
     ColorAlways -> return True
     ColorAuto -> fromMaybe True <$>
                           hSupportsANSIWithoutEmulation stderr
+  -- In certain situations the call to 'size' prints error messages on stderr even when the operation
+  -- succeeds, so we silence stderr to avoid these errors
   termWidth <- clipWidth <$> maybe (fromMaybe defaultTerminalWidth
-                                    <$> fmap (fmap width) size)
+                                    <$> fmap (fmap width) (hSilence [stderr] size))
                                    pure (globalTermWidth go)
   menv <- mkDefaultProcessContext
   logOptions0 <- logOptionsHandle stderr False