Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix the NPE in ProductSync Benchmark Test for SDK-v2 #874

Merged
merged 9 commits into from
Dec 7, 2022

Conversation

leungkinghin-ct
Copy link
Contributor

@leungkinghin-ct leungkinghin-ct commented Dec 6, 2022

Description
When we going to release new version, NPE is found when saving the benchmarks result for Product Sync with SDK-v2
The corresponding build failure :
https://github.com/commercetools/commercetools-sync-java/actions/runs/3629611330/jobs/6122914828

Cause

  • The benchmark result type for ProductSync with SDK-v2 is not yet defined in BenchmarkUtils.java

The NPE fix has been tested in CI build successfully when saving benchmark result.
https://github.com/commercetools/commercetools-sync-java/actions/runs/3630913001/jobs/6124846629

@leungkinghin-ct leungkinghin-ct changed the title Examine the build process Hotfix the NPE in ProductSync Benchmark Test for SDK-v2 Dec 6, 2022
@leungkinghin-ct leungkinghin-ct marked this pull request as ready for review December 6, 2022 15:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #874 (f48f348) into master (42ea44c) will not change coverage.
The diff coverage is n/a.

❗ Current head f48f348 differs from pull request most recent head 2a35a57. Consider uploading reports for the commit 2a35a57 to get more accurate results

@@            Coverage Diff            @@
##             master     #874   +/-   ##
=========================================
  Coverage     99.14%   99.14%           
  Complexity     2669     2669           
=========================================
  Files           225      225           
  Lines          7156     7156           
  Branches        440      440           
=========================================
  Hits           7095     7095           
  Misses           32       32           
  Partials         29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@leungkinghin-ct leungkinghin-ct merged commit db9718a into master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants