Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the minimum support to Java 11. #840

Merged
merged 9 commits into from
Aug 8, 2022
Merged

Conversation

praveenkumarct
Copy link
Contributor

Summary

Upgrade Java version minimum support from 8 to 11.

Description

We are missing updates from different libraries If we are still using Java 8 as minimum version, Hence upgraded to next stable version 11 as minimum version.

Relevant Issues

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #840 (446436d) into master (b8153df) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 446436d differs from pull request most recent head 38d37c2. Consider uploading reports for the commit 38d37c2 to get more accurate results

@@            Coverage Diff            @@
##             master     #840   +/-   ##
=========================================
  Coverage     99.17%   99.18%           
  Complexity     2684     2684           
=========================================
  Files           224      224           
  Lines          7175     7198   +23     
  Branches        442      440    -2     
=========================================
+ Hits           7116     7139   +23     
  Misses           31       31           
  Partials         28       28           
Impacted Files Coverage Δ
.../sync/products/utils/ProductUpdateActionUtils.java 95.87% <0.00%> (-0.03%) ⬇️
...in/java/com/commercetools/sync/types/TypeSync.java 100.00% <0.00%> (ø)
...a/com/commercetools/sync/products/ProductSync.java 100.00% <0.00%> (ø)
...om/commercetools/sync/categories/CategorySync.java 100.00% <0.00%> (ø)
...om/commercetools/sync/commons/BaseSyncOptions.java 100.00% <0.00%> (ø)
.../commercetools/sync/commons/utils/FilterUtils.java 100.00% <0.00%> (ø)
...mercetools/sync/commons/utils/GraphQlQueryAll.java 100.00% <0.00%> (ø)
...ercetools/sync/customobjects/CustomObjectSync.java 100.00% <0.00%> (ø)
...ls/sync/commons/utils/CustomUpdateActionUtils.java 100.00% <0.00%> (ø)
...ync/shoppinglists/utils/ShoppingListSyncUtils.java 100.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@leungkinghin-ct leungkinghin-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@praveenkumarct praveenkumarct merged commit 040556a into master Aug 8, 2022
@praveenkumarct praveenkumarct deleted the upgrade-java-8-to-11 branch August 8, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants