Support resource identifier on customer group in PriceDraft #676
Conversation
| * <p>Note: The key of the customer group reference taken from the value of the id field of the | ||
| * reference. | ||
| * <p>Note: The key of the customer group reference taken from the value of the key field of the | ||
| * resource identifier. |
There was a problem hiding this comment.
Do we need this Note? We can remove it, Since we don't have confusion anymore using key value in id field. wdyt?
| for those references you have to provide the `key` value on the `id` field of the reference. This means that calling `getId()` on the reference should return its `key`. | ||
|
|
||
| ````java | ||
| final PriceDraft priceDraft = PriceDraftBuilder |
There was a problem hiding this comment.
This example should not be removed, instead, you might update the customer group with ResourceIdentifier.ofKey..
I would move the sentence on line 120: Some references... with changing to,
- The product variant attributes with a type
ReferenceTypedo not support theResourceIdentifieryet, for those references you have to provide thekeyvalue on theidfield of the reference. This means that callinggetId()on the reference should return itskey.
There was a problem hiding this comment.
If update it with ResourceIdentifier.ofKey, this example is no longer related to ReferenceType.
Hence the example looks a bit irrelevant to line 120. wdyt?
There was a problem hiding this comment.
I was thinking that my comment is quite clear. Let me explain again:
The example code snippet should not be removed and should be updated with ofKey but the sentence above it would be better to move after this snippet example because it only explains the ReferenceType.
There was a problem hiding this comment.
It makes sense if we move the snippet before the sentence.
3cd0d9b
* master: fix deployment url. Add timeouts. remove duplicated text. Set lib versiob properly. Remove unneeded comment. Change checklist. Remove oss-publish step. Clean up docs. Add missing quote. use different urls for snapshot and release deployments. Cleanup. Add release version. Directly push artifacts to mvn central. Put additional note for the JDK compability. # Conflicts: # docs/README.md
…urceidentifier-for-customer-group # Conflicts: # build.gradle
Description
Change from Reference object to ResourceIdentifier object so that user can put customer group key into key field, not id field.
https://docs.commercetools.com/api/releases/2021-02-03-reference-customer-groups-by-key
Todo