Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullpointerException for products having a category but no order-… #1134

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

lojzatran
Copy link
Collaborator

Original PR: #1133

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d4ec809) 97.32% compared to head (3d603f6) 97.31%.

❗ Current head 3d603f6 differs from pull request most recent head e978e7b. Consider uploading reports for the commit e978e7b to get more accurate results

Files Patch % Lines
...ync/products/helpers/ProductReferenceResolver.java 0.00% 0 Missing and 1 partial ⚠️
...roducts/utils/ProductReferenceResolutionUtils.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1134      +/-   ##
============================================
- Coverage     97.32%   97.31%   -0.02%     
- Complexity     2686     2687       +1     
============================================
  Files           229      229              
  Lines          8521     8521              
  Branches        526      526              
============================================
- Hits           8293     8292       -1     
  Misses          142      142              
- Partials         86       87       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lojzatran lojzatran merged commit fbfbab7 into master Dec 21, 2023
6 checks passed
@lojzatran lojzatran deleted the fix_npe_category_order_hints branch December 21, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants