Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryAll bug #463

Closed
heshamMassoud opened this issue Oct 15, 2019 · 1 comment · Fixed by #464
Closed

QueryAll bug #463

heshamMassoud opened this issue Oct 15, 2019 · 1 comment · Fixed by #464

Comments

@heshamMassoud
Copy link
Contributor

Opened from a support ticket

I found a bug in the commercetools-sync-java:1.5.0 library.

I use the

CtpQueryUtils.queryAll(sphereClient, productQuery, pageCallback, pageSize).toCompletableFuture().join();

Static method to do a paged query.
My productQuery is:

ProductReferenceReplacementUtils.buildProductQuery()
.plusPredicates(m -> m.productType().is(ProductType.reference(productType)))

The result is, that I get in the FIRST page loop only products with the right product type and in all other loops all products. The reason is that the line

QueryAll.java:167 return client.execute(queryPredicate != null ? query.withPredicates(queryPredicate) : query);

Overwrites MY predicate. Therefore a solution would be to change the withPredicate to plusPredicate.
heshamMassoud added a commit that referenced this issue Oct 15, 2019
@heshamMassoud
#463: Use .plusPredicates instead of .withPredicates.
4ae4838
heshamMassoud added a commit that referenced this issue Oct 15, 2019
@heshamMassoud
#463: Add unit tests.
087cef7
heshamMassoud added a commit that referenced this issue Oct 15, 2019
@heshamMassoud
#463: Add release notes entry.
22c5414
heshamMassoud added a commit that referenced this issue Oct 15, 2019
@heshamMassoud
#463: Use Junit5 extend with instead of old run with.
df38aea
heshamMassoud added a commit that referenced this issue Oct 15, 2019
@heshamMassoud
#463: Make checkstyle happy.
3d8658d
@heshamMassoud heshamMassoud mentioned this issue Oct 15, 2019
Merged
2 tasks
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#463: Remove unnecessary stubbing.
82a2f53
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#463: Make algorithm more readable.
52918d7
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#463: Suppress Findbugs warning.
959f780
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#463: Add test for custom sort in query.
cc181bf
heshamMassoud added a commit that referenced this issue Oct 16, 2019
@heshamMassoud
#463: Fix queryAll bug.
99aaed9
@heshamMassoud
Copy link
Contributor Author

released in https://github.com/commercetools/commercetools-sync-java/releases/tag/1.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

463 fix query all commercetools/commercetools-sync-java
1 participant
@heshamMassoud