Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeUpdateCallback is called even on empty list of update actions #359

Closed
heshamMassoud opened this issue Dec 18, 2018 · 1 comment
Closed

beforeUpdateCallback is called even on empty list of update actions #359

heshamMassoud opened this issue Dec 18, 2018 · 1 comment
Assignees
@ahmetoz
Milestone
1.1.0

Comments

@heshamMassoud
Copy link
Contributor

Description

beforeUpdateCallback is called even on empty list of update actions

Current Behaviour

beforeUpdateCallback is called even on empty list of update actions

Expected Behaviour

beforeUpdateCallback shouldn't be called on empty list of update actions.

Context

It's confusing giving the name is beforeUpdate. Meaning it should only be called when there is something (update actions) to update on the product.
@heshamMassoud heshamMassoud added this to the 1.1.0 milestone Dec 18, 2018
ahmetoz added a commit that referenced this issue Dec 18, 2018
@ahmetoz
#359 add empty check for applyBeforeCallback
3bcc075
@ahmetoz ahmetoz mentioned this issue Dec 18, 2018
Merged
ahmetoz added a commit that referenced this issue Dec 18, 2018
@ahmetoz
#359 add release note
bedd52f
ahmetoz added a commit that referenced this issue Dec 18, 2018
@ahmetoz
#359 update java doc
29bdc28
ahmetoz added a commit that referenced this issue Dec 18, 2018
@ahmetoz
#359 refactor abstract classes to interfaces.
7005a84
ahmetoz added a commit that referenced this issue Dec 19, 2018
@ahmetoz
#359 reword callback
8fdcb46
ahmetoz added a commit that referenced this issue Dec 19, 2018
@ahmetoz
#359 change tense of java docs
a203c4f
ahmetoz added a commit that referenced this issue Dec 19, 2018
@ahmetoz
#359 fix formatting
17ba6aa
heshamMassoud added a commit that referenced this issue Dec 19, 2018
@heshamMassoud
#359: Use smaller commit sha.
71f5346
heshamMassoud added a commit that referenced this issue Dec 19, 2018
@heshamMassoud
#359: Fix comment message.
6df67d4
heshamMassoud added a commit that referenced this issue Dec 19, 2018
@heshamMassoud
Merge pull request #363 from commercetools/359-empty-list-filter-for-…
5dde47b 
…beforeUpdateCallback

#359 add empty check for applyBeforeCallback
@heshamMassoud
Copy link
Contributor Author

Released in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmetoz ahmetoz

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@ahmetoz @heshamMassoud