Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product "addVariant" action doesn't accept also variant assets #357

Closed
heshamMassoud opened this issue Dec 17, 2018 · 1 comment
Closed

Comments

@heshamMassoud
Copy link
Contributor

heshamMassoud commented Dec 17, 2018

Description

The Product addVariant update action doesn't accept variant assets. This means if we want to add a new variant with new assets we cannot with this action.

Current Behaviour

Assets are not synced with newly added variants.

Expected Behaviour

We have to append another "addAsset" action with it. Until it is supported by the platform here: Support request opened: https://jira.commercetools.com/servicedesk/customer/portal/1/SUPPORT-4603 (accessible by @heshamMassoud @ahmetoz @butenkor)

Context

Assets are not synced with newly added variants.

Possible Solution

one has to always check if there are new assets or not in the new variant and then add the "addAsset" action.

Future Todo

When the platform supports adding a new variant with the assets, appending an AddAsset action should be removed.

@heshamMassoud heshamMassoud added this to the 1.1.0 milestone Dec 17, 2018
heshamMassoud added a commit that referenced this issue Dec 18, 2018
heshamMassoud added a commit that referenced this issue Dec 18, 2018
heshamMassoud added a commit that referenced this issue Dec 18, 2018
heshamMassoud added a commit that referenced this issue Dec 18, 2018
heshamMassoud added a commit that referenced this issue Dec 18, 2018
heshamMassoud added a commit that referenced this issue Dec 19, 2018
heshamMassoud added a commit that referenced this issue Dec 19, 2018
@heshamMassoud
Copy link
Contributor Author

Released in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant