Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Failed Stats count on failed fetch of resource (esp. categories & productTypes) #331

Closed
heshamMassoud opened this issue Nov 7, 2018 · 2 comments
Closed

Investigate Failed Stats count on failed fetch of resource (esp. categories & productTypes) #331

heshamMassoud opened this issue Nov 7, 2018 · 2 comments
Assignees
@heshamMassoud
Labels
question ❓
Milestone
1.0.0-M15

Comments

@heshamMassoud
Copy link
Contributor

Description

Investigate Failed Stats count on failed fetch of resource (esp. categories & productTypes)

More info @ ProductTypeService#fetchMatchingProductTypes
@heshamMassoud heshamMassoud self-assigned this Nov 7, 2018
@heshamMassoud heshamMassoud added this to the 1.0.0-M15 milestone Nov 7, 2018
@heshamMassoud
Copy link
Contributor Author

More info: #316 (comment)

@ahmetoz ahmetoz mentioned this issue Nov 13, 2018
Merged
5 tasks
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Remove redundant returns.
fabd539
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Handle null cases for isRequired and isSearchable.
7e2673c
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Add unit tests for AttributeDefinitionCustomBuilder.
d3e4f6a
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Use CtpQueryUtils instead of QueryExecutionUtils.
33d9ed3
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Don't sync productTypes Batches if exception on fetch occurs.
5ac3ce2
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Make constructor not accessible except for unit tests.
76ffbdc
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Add unit tests for failed fetching on product type sync.
68124b0
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Fix indentation.
b97c7e7
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Handle product sync fail on fetch.
f7eb1c5
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Fix product service integration tests.
d8238f2
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Add unit test for failed fetch on product sync.
52ee673
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Improve product type sync ITs.
1ce139c
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Make chains more readable.
0679990
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Use better error message.
574110e
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Decouple fail on fetching from category service.
ee7f27a
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Short circuit on blank key and fetch from cache only if there.
35dc763
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Fix category service ITs.
2dee091
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Fix comments.
01f81eb
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Remove unneeded string.
04ab161
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Handle error on caching category keys.
b623abf
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Handle error on caching product keys.
e0ecc75
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Unit test handling of error on caching product keys.
198bb4c
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Unit test handling of error on caching and fetching of categories.
e559612
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Make service classes final.
aacf582
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Add mockito extension for stubbing final classes.
8c3de4e
@heshamMassoud heshamMassoud mentioned this issue Nov 26, 2018
Merged
4 tasks
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Fix Checkstyle.
2a9173f
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Suppress warnings of unsafe casting.
a4cba7d
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Improve error messages.
da44b18
heshamMassoud added a commit that referenced this issue Nov 26, 2018
@heshamMassoud
#331: Fix concurrency modification integration tests.
ee6042a
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Remove extra line.
58b679b
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Cover all concurrent modification product sync retries.
3d614c1
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Move unit test closer to sibling unit tests for the same target…
7bb41e1 
… method.
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Integration test blank key on fetchCachedCategoryId.
22a014b
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Fix error message.
1dd5a7a
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Adjust Javadocs.
08923d1
heshamMassoud added a commit that referenced this issue Nov 27, 2018
@heshamMassoud
#331: Add release notes.
b7bdb78
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#331: Make same service method Javadocs consistent.
feadff9
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#331: Make assertions consistent.
33deed8
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#331: Unignore productType failed fetch IT.
eadc8bd
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#331: Apply error callback suggestion.
fa2d2ff
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#331: Split lambda into smaller methods.
1a7e92c
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#331: Rename method to fix naming collision.
250222f
@heshamMassoud
Copy link
Contributor Author

heshamMassoud commented Dec 10, 2018 •
edited
Loading

Released in 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heshamMassoud heshamMassoud

Labels
question ❓
Projects
None yet
Milestone
1.0.0-M15
Development

No branches or pull requests
1 participant
@heshamMassoud