Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductSync should resolve customTypes on prices #277

Closed
ValeSauer opened this issue Jun 4, 2018 · 1 comment
Closed

ProductSync should resolve customTypes on prices #277

ValeSauer opened this issue Jun 4, 2018 · 1 comment
Labels
product-sync reference-resolution 🔗

Comments

@ValeSauer
Copy link
Contributor

Whenever a price in the sync source has a customType, productSync fails because it cannot resolve references to types on prices.
ValeSauer pushed a commit that referenced this issue Jun 4, 2018
#277: Resolve references to price types
7dab9dd
@ValeSauer ValeSauer changed the title ProductSync should resolve customTypes on pries ProductSync should resolve customTypes on prices Jun 4, 2018
@ValeSauer ValeSauer mentioned this issue Jun 4, 2018
Merged
4 tasks
ValeSauer pushed a commit that referenced this issue Jun 4, 2018
#277: Fix checkstyle issues
2db3276
ValeSauer pushed a commit that referenced this issue Jun 4, 2018
#277: Resolve references to price types
4df94a7
ValeSauer pushed a commit that referenced this issue Jun 4, 2018
#277: Avoid star imports
b571b29
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Refactor ProductSyncMockUtils#getPriceMockWithReferences to acc…
ab06cc6 
…ept price custom type references as well as channel references.
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Refactor ProductITUtils#getDraftWithPriceReferences to accept C…
34c6963 
…ustomFieldsDraft as well.
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Create new util ProductSyncMockUtils#createPricesCustomType to …
7225166 
…to create a price custom type on the supplied cup client.
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Remove unneeded method call.
5ba7bf9
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Assert all references are expanded appropriately by ProductRefe…
2406d85 
…renceReplacementUtils#buildProductQuery.
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Update Javadocs.
f368140
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Refactor and update unit tests for VariantReferenceReplacementU…
3f3cc8c 
…tils#replacePricesReferencesIdsWithKeys.
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Fix typos in RELEASE_NOTES.md.
6ddc652
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Prepare for new release M13.
b0ffc5f
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Fix grammatical typo.
8682be7
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
#277: Refactor duplicated code block for reuse.
6619e70
heshamMassoud added a commit that referenced this issue Jun 5, 2018
@heshamMassoud
Merge pull request #278 from commercetools/277-price-type-references
5d2ceee 
#277: Resolve references to price types
@heshamMassoud
Copy link
Contributor

released in v1.0.0-M12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
product-sync reference-resolution 🔗
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValeSauer @heshamMassoud