Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring all services to extend from BaseService #198

Closed
heshamMassoud opened this issue Nov 30, 2017 · 3 comments
Closed

Consider refactoring all services to extend from BaseService #198

heshamMassoud opened this issue Nov 30, 2017 · 3 comments
Labels
enhancement ⬆️
Milestone
backlog

Comments

@heshamMassoud
Copy link
Contributor

Consider refactoring all services to extend from BaseService.

Currently ProductService and CategoryService are extending it. Later all other services should also extend it and be refacored for reuse.
@heshamMassoud heshamMassoud mentioned this issue Nov 30, 2017
Merged
@heshamMassoud heshamMassoud added this to the backlog milestone Feb 9, 2018
@heshamMassoud heshamMassoud mentioned this issue Dec 4, 2018
Closed
@heshamMassoud
Copy link
Contributor Author

Consider decoupling sync options from services (especially the error callback being called in the createResource in the BaseService)#345

@heshamMassoud heshamMassoud mentioned this issue Dec 4, 2018
Merged
4 tasks
@heshamMassoud
Copy link
Contributor Author

InventoryService still needs to also be made consistent with other services.

@heshamMassoud heshamMassoud mentioned this issue Jul 16, 2019
Closed
@jarzynp jarzynp mentioned this issue Jul 17, 2019
Closed
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Fix formatting.
867a93d
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Fix formatting.
784ff54
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Make ChannelService extend BaseService.
7680b94
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Refactor Inventory sync.
82c08e5
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Refactor InventoryEntryIdentifier.
84093e0
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Refactor service classes.
2f5a078
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Fix tests.
c936b79
heshamMassoud added a commit that referenced this issue Dec 12, 2019
@heshamMassoud
#198: Use generic implementation for TaxCategoryService, StateService…
623e3ae 
… and CustomerGroupService.
@heshamMassoud heshamMassoud mentioned this issue Dec 12, 2019
Merged
heshamMassoud added a commit that referenced this issue Dec 13, 2019
@heshamMassoud
#198: Fix and remove unneeded tests.
ae3b85a
heshamMassoud added a commit that referenced this issue Dec 13, 2019
@heshamMassoud
#198: Add more coverage for InventoryEntryIdentifier#equals.
423ed03
heshamMassoud added a commit that referenced this issue Jan 16, 2020
@heshamMassoud
#198: Remove changes on release notes.
40d498d
heshamMassoud added a commit that referenced this issue Jan 16, 2020
@heshamMassoud
#198: Remove changes on release notes.
549ac67
heshamMassoud added a commit that referenced this issue Jan 17, 2020
@heshamMassoud
#198: Change name of KeyBasedService to BaseServiceWithKey.
ad692bf
heshamMassoud added a commit that referenced this issue Jan 17, 2020
@heshamMassoud
#198: Add release notes entry.
b697eb3
heshamMassoud added a commit that referenced this issue Jan 17, 2020
@heshamMassoud
#198: Use string.format instead of concatenation.
e422c69
heshamMassoud added a commit that referenced this issue Jan 17, 2020
@heshamMassoud
#198: Fix javadoc.
d61882f
heshamMassoud added a commit that referenced this issue Jan 17, 2020
@heshamMassoud
#198: Make Checkstyle happy.
a626508
heshamMassoud added a commit that referenced this issue Jan 17, 2020
@heshamMassoud @jarzynp @ahmetoz
#198: Inventory service fetches channels on demand.
b152aa9 
* #418: BaseService improvement

* #418: Refactor and review PR.

* #418: Fix deprecated method.

* #418: Fix ITs.

* #418: Fix formatting.

* #418: Add release notes entry.

* #418: Fix release notes.

* #198: Fix formatting.

* #198: Fix formatting.

* #198: Make ChannelService extend BaseService.

* #198: Refactor Inventory sync.

* #198: Refactor InventoryEntryIdentifier.

* #198: Refactor service classes.

* #198: Fix tests.

* #198: Use generic implementation for TaxCategoryService, StateService and CustomerGroupService.

* #198: Fix and remove unneeded tests.

* #198: Add more coverage for InventoryEntryIdentifier#equals.

* #198: Remove changes on release notes.

* #198: Remove changes on release notes.

* #397: Fix all Javadocs.

* #198: Change name of KeyBasedService to BaseServiceWithKey.

* #198: Add release notes entry.

* #198: Use string.format instead of concatenation.

* #198: Fix javadoc.

* #198: Make Checkstyle happy.

* Update wording.

Co-Authored-By: Ahmet Öz <[email protected]>

* Fix javadoc.

Co-authored-by: Piotr Jarzyński <[email protected]>
Co-authored-by: Ahmet Öz <[email protected]>
@heshamMassoud
Copy link
Contributor Author

released in 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ⬆️
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
1 participant
@heshamMassoud