Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle routes with no time #60

Open
adeebshihadeh opened this issue Jul 11, 2024 · 2 comments · May be fixed by #69 or #99
Open

Handle routes with no time #60

adeebshihadeh opened this issue Jul 11, 2024 · 2 comments · May be fixed by #69 or #99
Labels
bounty enhancement New feature or request
Milestone
1.0

Comments

@adeebshihadeh
Copy link
Contributor

Since openpilot 0.9.7 removed RTC support, some routes can have no time (e.g. the device just booted up and didn't get a GPS fix during the route).

Since openpilot's uploader guarantees that routes are uploaded in the order they were created, we can still show all routes in the correct sequence using the create_time attribute of the route.

Requirements

  • hide the date/time
  • show "timeless" routes in the correct order with the rest of routes
@adeebshihadeh adeebshihadeh added the enhancement New feature or request label Jul 11, 2024
@adeebshihadeh adeebshihadeh added this to the 1.0 milestone Jul 11, 2024
@adeebshihadeh adeebshihadeh mentioned this issue Jul 11, 2024
Open
@vishalkrishnads vishalkrishnads linked a pull request Jul 12, 2024 that will close this issue
Open
@eshaanrathi2
Copy link

I would like to work on this. @adeebshihadeh

tex-murphy added a commit to tex-murphy/comma-new-connect that referenced this issue Aug 19, 2024
@tex-murphy
fix: sort routes without start_time/end_time
809d4ed 
- falls back to `create_time` when start_time/end_time are unavailable
- refactor `<RouteHeader />` into its own file
- hide `<RouteStatistics />` if there's no trip data

closes commaai#60
@tex-murphy tex-murphy linked a pull request Aug 19, 2024 that will close this issue
Open
@pauljones0 pauljones0 mentioned this issue Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty enhancement New feature or request
Projects
openpilot bounties
Status: Open
Milestone
1.0
3 participants
@adeebshihadeh @eshaanrathi2 and others