Merge pull request #2458 from comit-network/release/0.7.3

Release version 0.7.3

.circleci/config.yml

@@ -94,15 +94,15 @@ commands:
   install_lnd:
     steps:
       - run:
-          name:  "Install go 1.13 & lnd"
+          name:  "Install go 1.13 & lnd v0.9.1-beta"
           command: |
             sudo rm -rf /usr/local/go
             wget https://dl.google.com/go/go1.13.3.linux-amd64.tar.gz
             sudo tar -xzvf go1.13.3.linux-amd64.tar.gz -C /usr/local/
             unset GOPATH
             go get -d github.com/lightningnetwork/lnd
             cd ~/go/src/github.com/lightningnetwork/lnd
-            git checkout v0.9.0-beta
+            git checkout v0.9.1-beta
             make tags=invoicesrpc && make tags=invoicesrpc install
             echo 'export PATH=$HOME/.cargo/bin:$HOME/.local/bin:$HOME/go/bin:$PATH' >> $BASH_ENV
   print_current_versions:

.github/workflows/ci.yml

@@ -0,0 +1,124 @@
+name: CI
+
+on:
+  push:
+    branches-ignore:
+      - 'staging.tmp'
+      - 'trying.tmp'
+
+jobs:
+  static_analysis:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v1
+
+      - name: Extract toolchain version from rust-toolchain
+        run: echo "::set-env name=RUST_TOOLCHAIN::$(cat rust-toolchain)"
+
+      - name: Install ${{ env.RUST_TOOLCHAIN }} toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: ${{ env.RUST_TOOLCHAIN }}
+          override: true
+
+      - name: Cache ~/.cargo/bin directory
+        uses: actions/cache@v1
+        with:
+          path: ~/.cargo/bin
+          key: ubuntu-rust-${{ env.RUST_TOOLCHAIN }}-cargo-bin-directory
+
+      - name: Check formatting
+        run: make check_format
+
+      - name: Run linter
+        run: make clippy
+
+  build:
+    strategy:
+      matrix:
+        os: [macos-latest, ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v1
+
+      - name: Extract toolchain version from rust-toolchain
+        run: echo "::set-env name=RUST_TOOLCHAIN::$(cat rust-toolchain)"
+
+      - name: Install ${{ env.RUST_TOOLCHAIN }} toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: ${{ env.RUST_TOOLCHAIN }}
+          override: true
+
+      - name: Cache target directory
+        uses: actions/cache@v1
+        with:
+          path: target
+          key: ${{ matrix.os }}-rust-${{ env.RUST_TOOLCHAIN }}-target-directory-${{ hashFiles('Cargo.lock') }}
+
+      - name: Cache ~/.cargo/registry directory
+        uses: actions/cache@v1
+        with:
+          path: ~/.cargo/registry
+          key: ${{ matrix.os }}-rust-${{ env.RUST_TOOLCHAIN }}-cargo-registry-directory-${{ hashFiles('Cargo.lock') }}
+
+      - name: Build ${{ matrix.os }} binary
+        run: make build
+
+      # Ignore tests on macos due to missing docker
+      - name: Run unit tests
+        if: matrix.os != 'macos-latest'
+        run: make test
+
+      - name: Upload cnd-${{ matrix.os }} archive that contains the cnd binary
+        uses: actions/upload-artifact@v1
+        with:
+          name: cnd-${{ matrix.os }}
+          path: target/debug/cnd
+
+  e2e_test:
+    strategy:
+      matrix:
+        os: [macos-latest, ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    needs: build
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v1
+
+      - name: Download cnd-${{ matrix.os }} archive and extract cnd binary
+        uses: actions/download-artifact@v1
+        with:
+          name: cnd-${{ matrix.os }}
+          path: target/debug/
+
+      - name: Fix missing executable permission
+        run: |
+          chmod a+x target/debug/cnd
+
+      - name: Install NodeJS 12.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: '12.x'
+
+      - name: Install Go 1.13.3.
+        uses: actions/setup-go@v1
+        with:
+          go-version: '1.13.3'
+
+      - name: Install LND v0.9.1-beta
+        run: |
+          go get -d github.com/lightningnetwork/lnd
+          cd ~/go/src/github.com/lightningnetwork/lnd
+          git checkout v0.9.1-beta
+          make tags=invoicesrpc
+          make tags=invoicesrpc install
+
+      - name: Run e2e tests
+        run: |
+          export PATH=$HOME/.cargo/bin:$HOME/.local/bin:$HOME/go/bin:$PATH
+          make ci_gha

.gitignore

@@ -61,3 +61,5 @@ TAGS
 # Blockchain nodes artifacts
 blockchain_nodes/bitcoin/
 blockchain_nodes/parity/parity
+.yalc
+yalc.lock

CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.7.3] - 2020-04-14
+
+### Fixed
+
+-   Deserialization problem of bitcoind's response: Bitcoind returns as chain/network either `main`,`test` or `regtest`. This fix was manually tested against bitcoind (0.17, 0.18 and 0.19).
+
+### Changed
+
+-   Ensure that lnd parameters are defaulted if not present.
+
 ## [0.7.2] - 2020-03-26
 
 ## [0.7.1] - 2020-03-12
@@ -111,7 +121,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 -   Move config files to standard location based on platform (OSX, Windows, Linux).
 -   Align implementation with RFC-002 to use the decision header instead of status codes.
 
-[Unreleased]: https://github.com/comit-network/comit-rs/compare/0.7.2...HEAD
+[Unreleased]: https://github.com/comit-network/comit-rs/compare/0.7.3...HEAD
+
+[0.7.3]: https://github.com/comit-network/comit-rs/compare/0.7.2...0.7.3
 
 [0.7.2]: https://github.com/comit-network/comit-rs/compare/0.7.1...0.7.2