Skip to content

Conversation

christopher-comet
Copy link
Contributor

https://comet-ml.atlassian.net/browse/DT-560

Also added a statebackend.tf file that can be uncommented and filled out if desired.

Tested with both with and without declaring a vpc_cidr in the .tfvars. Smoke-tested Comet in one of the deploys as well.

Should be good to merge.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Kubernetes (EKS) default version and adds a new VPC CIDR variable to better configure the VPC resources. It also introduces a commented-out state backend configuration file for Terraform state management.

  • Introduces a new variable "vpc_cidr" in several modules for consistency.
  • Updates the default Kubernetes version from 1.27 to 1.32.
  • Adds a template "statebackend.tf" file for optional S3 backend configuration.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
variables.tf Added "vpc_cidr" variable and updated EKS version.
terraform.tfvars Comments out environment_tag and adds VPC CIDR hints.
statebackend.tf Provides instructions for S3 backend configuration.
modules/comet_vpc/variables.tf Added "vpc_cidr" variable for the VPC module.
modules/comet_vpc/main.tf Uses the variable "vpc_cidr" instead of a hard-coded value.
main.tf Passes "vpc_cidr" into the VPC module.
Comments suppressed due to low confidence (2)

variables.tf:157

  • Please update relevant documentation to indicate that the default EKS cluster version has been updated from 1.27 to 1.32 to ensure consistency with supported module versions.
default     = "1.32"

terraform.tfvars:14

  • If commenting out the environment_tag is intentional, please update the associated documentation or comments to clarify this configuration choice for future maintainers.
# environment_tag = "deployment-development"

@christopher-comet christopher-comet merged commit d5d4909 into main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants