Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to ESM syntax #48

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Change to ESM syntax #48

merged 1 commit into from
Dec 1, 2023

Conversation

danswann
Copy link
Member

@danswann danswann commented Dec 1, 2023

Docusaurus v3 supports using ESM syntax in project files.

This changes our existing code that uses CommonJS syntax (only docusaurus.config.js at the moment).

NB: this is not the same as setting "type":"module" in package.json, which Docusaurus does not support in my testing.
Instead, this uses ESM syntax in Docusaurus project files, which are transpiled behind the scenes by Docusaurus at build time.

Fixes #47.

Copy link
Member

@tukib tukib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the future is now 🤩

@danswann danswann merged commit 40e8ce6 into main Dec 1, 2023
3 checks passed
@danswann danswann deleted the daniel/esm-syntax branch December 1, 2023 03:08
This was referenced Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The project is configured for CommonJS, but will rely on ESM-only packages for some plugins
2 participants