-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acct_nt (T2 Lock) #463
Conversation
Adds a full description and explanation of every mode and every way acct_nt can behave.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All articles should be written in third person with no referential nouns (e.g. you, your), except for Tutorials, FAQs, and Writeups.
Fix you Co-authored-by: Zachava96 <[email protected]>
Co-authored-by: Zachava96 <[email protected]>
Co-authored-by: Zachava96 <[email protected]>
Co-authored-by: Zachava96 <[email protected]>
Co-authored-by: Zachava96 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total spent/earned actually uses net, not just incoming or outgoing, my bad
Thanks both of you! I was going to see about merging but looks like there is still discussion. I think it doesn't have to be perfect. Someone can always fix it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file should be moved to docs/upgrades/locks so that it shows up in the locks list. Currently the page doesn't show up at all I think.
You can do it with
git mv acct_nt.mdx docs/upgrades/locks/
and then commit, push as usual.
I would just do this but I don't want to cause confusion for ongoing work on the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I checked in codespaces and it looks good to me.
I am not checking for 100% accuracy since I don't think I've ever fully understood how acct_nt works, but I think that's fine.
I only have one question: do the stats and behavior sections contain spoilers? I've seen the README definition but I'm not sure exactly what it means. 😄
I don't know how much it matters though.
I don't think they do? It's pretty obvious that accts.transactions is nesseceary but if not, I can change that. |
The meaning of |
acct_nt_min as close to my understanding is correct, since acct_nt uses a range of transactions and acct_nt_min is how small that range can be |
Just to be safe, I will add a spoiler commit, you can tell me if it looks good to you? By the way, just curious, are you able to push the "Squash and merge" button when it turns green? I don't know who has permission. If you are able, you should feel free to push it, IMO. |
I do not have write access so no |
Ok, it was probably unnecessary, but added some spoiler guards. If it looks good to you I will merge? Thanks for your contribution! |
Yep |
Adds a full description and explanation of every mode and every way acct_nt can behave.
Problem
Fixes #461