Repository navigation
chore(workflows): remove dependabot-rebase.yml — not needed for non-strict repo - #82
Merged
Merged
Conversation
…trict repo Closes #79. The dependabot-rebase reusable exists to handle the case where branch protection requires "branches must be up to date" (strict required- status-checks). When a Dependabot PR falls behind main, the rebase workflow uses a GitHub App token to merge main into the PR branch and then merge the PR, forming a self-sustaining serialized chain. This repo does NOT enforce strict status checks: - ruleset 14805960 (code-quality): strict_required_status_checks_policy=false - ruleset 14759908 (protect-branches): strict_required_status_checks_policy=false - no classic branch protection on main Without strict checks, Dependabot PRs that fall behind can merge as-is, so the rebase workflow has nothing useful to do. It was being added on every CI run and failing immediately with: Secret APP_ID is required, but not provided while calling. Secret APP_PRIVATE_KEY is required, but not provided while calling. Removing the workflow eliminates the failure noise and removes the need for repo-level GitHub App secrets here entirely. Per the updated standards/dependabot-policy.md (combsmith/.github#97), dependabot-rebase.yml is now documented as optional and only required when strict status checks are enforced. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Pull request overview
Removes the dependabot-rebase GitHub Actions workflow stub from this repo, aligning with the stated policy that the rebase helper is only needed when strict “branch must be up to date” protection is enforced.
Changes:
- Delete
.github/workflows/dependabot-rebase.yml(thin caller stub to an org-level reusable workflow).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
don-petry
added a commit
that referenced
this pull request
Jun 10, 2026
…trict repo (#82) Closes #79. The dependabot-rebase reusable exists to handle the case where branch protection requires "branches must be up to date" (strict required- status-checks). When a Dependabot PR falls behind main, the rebase workflow uses a GitHub App token to merge main into the PR branch and then merge the PR, forming a self-sustaining serialized chain. This repo does NOT enforce strict status checks: - ruleset 14805960 (code-quality): strict_required_status_checks_policy=false - ruleset 14759908 (protect-branches): strict_required_status_checks_policy=false - no classic branch protection on main Without strict checks, Dependabot PRs that fall behind can merge as-is, so the rebase workflow has nothing useful to do. It was being added on every CI run and failing immediately with: Secret APP_ID is required, but not provided while calling. Secret APP_PRIVATE_KEY is required, but not provided while calling. Removing the workflow eliminates the failure noise and removes the need for repo-level GitHub App secrets here entirely. Per the updated standards/dependabot-policy.md (combsmith/.github#97), dependabot-rebase.yml is now documented as optional and only required when strict status checks are enforced. Co-authored-by: DJ <dj@Rachels-MacBook-Air.local> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
don-petry
added a commit
that referenced
this pull request
Jun 21, 2026
…trict repo (#82) Closes #79. The dependabot-rebase reusable exists to handle the case where branch protection requires "branches must be up to date" (strict required- status-checks). When a Dependabot PR falls behind main, the rebase workflow uses a GitHub App token to merge main into the PR branch and then merge the PR, forming a self-sustaining serialized chain. This repo does NOT enforce strict status checks: - ruleset 14805960 (code-quality): strict_required_status_checks_policy=false - ruleset 14759908 (protect-branches): strict_required_status_checks_policy=false - no classic branch protection on main Without strict checks, Dependabot PRs that fall behind can merge as-is, so the rebase workflow has nothing useful to do. It was being added on every CI run and failing immediately with: Secret APP_ID is required, but not provided while calling. Secret APP_PRIVATE_KEY is required, but not provided while calling. Removing the workflow eliminates the failure noise and removes the need for repo-level GitHub App secrets here entirely. Per the updated standards/dependabot-policy.md (combsmith/.github#97), dependabot-rebase.yml is now documented as optional and only required when strict status checks are enforced. Co-authored-by: DJ <dj@Rachels-MacBook-Air.local> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79.
Why
The
dependabot-rebasereusable exists to handle the case where branch protection requires "branches must be up to date" (strict required-status-checks). This repo does NOT enforce strict status checks:strict_required_status_checks_policy=falsestrict_required_status_checks_policy=falsemainWithout strict checks, Dependabot PRs that fall behind can merge as-is, so the rebase workflow has nothing useful to do. It was being added on every CI run and failing immediately with:
Removing the workflow eliminates the failure noise and removes the need for repo-level GitHub App secrets here entirely.
Per the updated
standards/dependabot-policy.md(combsmith/.github#97),dependabot-rebase.ymlis now documented as optional and only required when strict status checks are enforced.Test plan
Dependabot update and mergeworkflow no longer runs🤖 Generated with Claude Code
Summary by CodeRabbit