Skip to content

feat: implement issue #135 — Compliance: check-suite-auto-trigger-347564 - #230

Closed
don-petry wants to merge 13 commits into
mainfrom
dev-lead/issue-135-20260530-1355
Closed

don-petry wants to merge 13 commits into
mainfrom
dev-lead/issue-135-20260530-1355

Conversation

@don-petry

@don-petry don-petry commented May 30, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #135

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated repository settings workflow trigger configuration
    • Removed duplicate entries from .gitignore

Copilot AI review requested due to automatic review settings May 30, 2026 13:58
@don-petry
don-petry requested a review from a team as a code owner May 30, 2026 13:58
@coderabbitai

coderabbitai Bot commented May 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 44 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 84c8942b-1eb2-4e03-b9af-5fc2023d0496

📥 Commits

Reviewing files that changed from the base of the PR and between b5abf44 and 5654049.

📒 Files selected for processing (2)
  • .github/workflows/apply-repo-settings.yml
  • .gitignore
📝 Walkthrough

Walkthrough

This PR contains two small repository configuration updates: the "Apply repository settings" workflow trigger is simplified to run on every push to main (removing the previous path filter that limited it to script changes), and the .gitignore file has duplicate .dev-lead/ entries removed from the repository-specific section.

Changes

Repository Settings and Configuration Cleanup

Layer / File(s) Summary
Workflow trigger simplification
.github/workflows/apply-repo-settings.yml
The push trigger for the apply-repo-settings workflow no longer filters by path, allowing it to execute on every push to main while preserving the workflow_dispatch manual trigger.
.gitignore deduplication
.gitignore
Removes a long sequence of duplicated .dev-lead/ ignore patterns from the bmad-bgreat-suite section, consolidating to fewer entries while maintaining the intent to ignore those directories.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly references issue #135 and the compliance check being addressed, accurately reflecting the main objective of the pull request.
Linked Issues check ✅ Passed The PR addresses issue #135 by modifying the workflow trigger and cleaning up .gitignore, which aligns with the remediation requirement to bring repository settings into compliance.
Out of Scope Changes check ✅ Passed The .gitignore cleanup appears to be a supplementary maintenance task; while not directly required by issue #135, it is a minor related cleanup that does not contradict the linked requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-135-20260530-1355

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a duplicate entry for .dev-lead/ to the .gitignore file. The feedback correctly identifies that this entry is already present multiple times and recommends removing the redundant line to keep the file clean.

Comment thread .gitignore
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 30, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses compliance issue #135 (CodeRabbit auto-trigger blocking auto-merge). The fix relies on the existing scripts/apply-repo-settings.sh, which already disables CodeRabbit (app 347564) and Claude (app 1236702) auto-triggers via the GitHub check-suites preferences API. To make merging this PR actually re-apply those settings, the workflow's paths: filter is dropped so it runs on every push to main. The PR also cleans up a large block of accidentally duplicated .dev-lead/ lines (and stray trigger comments) that had accumulated in .gitignore from previous compliance PRs.

Changes:

  • Remove the paths: filter on apply-repo-settings.yml so the workflow re-applies settings on every push to main, not just when the script itself changes.
  • Strip ~100 duplicate .dev-lead/ entries and stale # compliance-ci-trigger / # ci-trigger-179 marker comments from .gitignore.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/apply-repo-settings.yml Drops the scripts/apply-repo-settings.sh path filter so merging any change to main triggers a settings re-application, including this PR (which is how the CodeRabbit auto-trigger gets disabled).
.gitignore Removes accumulated duplicate .dev-lead/ lines and stray trigger-marker comments left behind by prior compliance PRs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry
don-petry enabled auto-merge (squash) May 30, 2026 14:11
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 31, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3404d4ba9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/apply-repo-settings.yml
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 31, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 31, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:11

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: check-suite-auto-trigger-347564

3 participants