Skip to content

chore(dev-lead): retire the legacy claude issue-trigger label #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 1 commit into from
Jun 6, 2026
Merged

chore(dev-lead): retire the legacy claude issue-trigger label #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/dev-lead/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Every GitHub webhook event that reaches `dev-lead.yml` is classified into exactl
| `issue_comment` created on PR | Trusted bot (`sonarqubecloud[bot]`, `coderabbitai[bot]`) | `fix-bot-comment` | `dev-lead-fix-reviews.sh` |
| `issue_comment` created on PR | Human OWNER/MEMBER/COLLABORATOR + trigger phrase | `human` | `dev-lead-fix-reviews.sh` |
| `issue_comment` created on PR | `<!-- auto-rebase-conflict:` marker | `rebase` | `dev-lead-fix-reviews.sh` |
| `issues` labeled `dev-lead` or `claude` | Any | `issue` | `dev-lead-fix-issue.sh` |
| `issues` labeled `dev-lead` | Any | `issue` | `dev-lead-fix-issue.sh` |
| `check_run` completed, failure | Not a `dev-lead /` check | _relay only_ | `ci-relay` job |
| `repository_dispatch` `dev-lead-ci-failure` | Dispatched by `ci-relay` | `fix-ci` | `dev-lead-fix-ci.sh` |
| All others | — | `skip` | (no-op) |
Expand All @@ -123,7 +123,7 @@ Every GitHub webhook event that reaches `dev-lead.yml` is classified into exactl

**`human-pr`** — A new PR was opened/synchronized or a human submitted a review. The agent reads the PR and all open review threads, addresses anything it can, and posts a status comment.

**`issue`** — An issue was labeled `dev-lead` or `claude`. The agent implements the issue, opens a PR, self-reviews, and tags CODEOWNERS when CI is green.
**`issue`** — An issue was labeled `dev-lead`. The agent implements the issue, opens a PR, self-reviews, and tags CODEOWNERS when CI is green.

**`rebase`** — An auto-rebase-conflict sentinel comment was posted on a PR. The agent performs an agentic rebase, resolving conflicts per the conflict-resolution strategy, and pushes.

Expand Down
4 changes: 2 additions & 2 deletions scripts/dev-lead-intent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ set -euo pipefail
# fix-bot-comment — Bot issue comment to address
# on-mention — Human-directed @mention task
# review-changes — Human review changes-requested
# issue — Issue labeled dev-lead/claude
# issue — Issue labeled dev-lead
# rebase — Rebase conflict sentinel
# enable-auto-merge — Bot approval: enable auto-merge if PR is APPROVED
# ci-relay — check_run relay (handled by ci-relay job, not this script)
Expand Down Expand Up @@ -322,7 +322,7 @@ case "$EVENT_NAME" in
label_name=$(jq -r '.label.name // empty' "$EVENT_PATH" 2>/dev/null || true)
issue_number=$(jq -r '.issue.number // empty' "$EVENT_PATH" 2>/dev/null || true)
case "$label_name" in
dev-lead|claude)
dev-lead)
context=$(printf '{"issue_number":%s}' "${issue_number:-0}")
emit_intent "issue" "issue-labeled-${label_name}" "$context"

This comment was marked as resolved.

Sign in to view

@donpetry-bot donpetry-bot Jun 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the variable gives flexiblity, keep as is

;;
Expand Down
6 changes: 4 additions & 2 deletions tests/dev-lead/unit/test_intent_issue.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,16 @@ _get_context_field() {
[ "$(_get_env INTENT_TYPE)" = "issue" ]
}

@test "issue: issues labeled claude → issue (backward compat)" {
@test "issue: issues labeled claude → skip (legacy label retired)" {
# The `claude` label was retired in favour of `dev-lead`; it no longer
# triggers the issue intent.
export GITHUB_EVENT_NAME="issues"
export GITHUB_EVENT_PATH="$FIXTURES_DIR/issues_labeled_claude.json"

Comment on lines 57 to 59
run bash "$INTENT_SCRIPT"

[ "$status" -eq 0 ]
[ "$(_get_env INTENT_TYPE)" = "issue" ]
[ "$(_get_env INTENT_TYPE)" = "skip" ]
}

@test "issue: issues labeled bug → skip" {
Expand Down
Loading