Repository navigation
Onboard scrum-master persona (missed by #1303 auto-merge race) - #1305
Conversation
#1303 auto-merged on its 3-persona state moments before the scrum-master commit landed, so scrum-master never reached main (the squash even kept the old 3-persona title). The team petry-projects/scrum-master already exists; this lands the files. - personas/scrum-master/persona.yml — draft; framework-agent → vendored bmad-method sprint-planning (v6.8.0) with local_overrides → the org wrapper prompts/bmad/scrum-master.md, plus workflow-prompts → prompts/bmad. Advisory on mention/issues/discussion. Role, not a person (§1.6). - prompts/scrum-master/advisory.md — decomposition/scoping/sequencing advice (read-only/sentinel/marker contract). - README + seed held-out evals (churn-trap cases: too-coarse, missing AC, cyclic blocked_by, and a "don't over-engineer a sound plan" negative). Verification (against LIVE main — #779 schema + #1302 validator both merged): - validate-personas.py: 5/5 valid, invariants hold. - validate-cases.py: OK, 9 skills / 75 cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 31 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Scrum Master persona, including its manifest, README, advisory prompt, and initial evaluation cases. The review feedback correctly identifies a mismatch between the required five minimum evaluation cases specified in the manifest and the four cases actually provided, suggesting either adjusting the minimum case count or adding a fifth case to resolve the inconsistency.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
There was a problem hiding this comment.
Pull request overview
This PR adds the missing scrum-master persona artifacts to .github-private, making the role addressable as @petry-projects/scrum-master and wiring it into the existing persona manifest + advisory + evals structure used by the org’s mention-driven persona runner.
Changes:
- Adds the Scrum Master persona manifest (
personas/scrum-master/persona.yml) as a draft, wrapping the vendored BMAD sprint-planning skill and the org orchestration wrapper. - Adds the headless advisory prompt (
prompts/scrum-master/advisory.md) for mention/issue/discussion advisory mode. - Seeds initial dev + holdout eval case sets under
evals/scrum-master/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| prompts/scrum-master/advisory.md | Adds the headless advisory prompt and output contract for the scrum-master role. |
| personas/scrum-master/README.md | Documents the scrum-master persona, status, and addressability via org team handle. |
| personas/scrum-master/persona.yml | Introduces the draft persona manifest (definition layers, triggers, trust, eval gate metadata). |
| evals/scrum-master/holdout/cases.jsonl | Seeds initial holdout eval cases for sequencing/decomposition behavior. |
| evals/scrum-master/dev/cases.jsonl | Seeds initial dev eval cases for decomposition and acceptance-criteria guidance. |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
|
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 78a5fe610017e0df8b0b6d78d41c95a3059ab14d
Review mode: triage-approved (single reviewer)
Summary
Additive onboarding of the scrum-master persona (5 new files: draft manifest, README, headless advisory prompt, 4 eval cases) after #1303's auto-merge race dropped them. No workflow, script, or auth-surface changes. Bot review feedback was addressed in the head commit; all review threads resolved; coderabbitai approved.
Linked issue analysis
No linked issues. PR body explains the motivation: #1303 auto-merged on a stale 3-persona state before the scrum-master commit landed, so this PR lands the missing files. The team petry-projects/scrum-master already exists; changes match that stated scope exactly.
Findings
- All 4 bot review threads (gemini-code-assist, Copilot) are resolved; head commit 78a5fe6 fixed the min_cases mismatch (now 4, matching the 4 eval cases), added the $AGENT_MARKER first line to the advisory-shape example, and added the create-story skill reference.
- Verified all referenced paths exist on main: the vendored bmad-sprint-planning and bmad-create-story skills and the org wrapper prompts/bmad/scrum-master.md.
- Persona is draft, advisory-only, with a recursion-guard marker rule and an author-association trust floor (OWNER/MEMBER/COLLABORATOR) — consistent with existing persona patterns; validate-personas and verify-persona-teams checks pass.
- MCP secret scanning tool unavailable in this run; gitleaks CI secret scan passed and the diff contains no secret-like content.
- Triage assessment (low-risk) confirmed.
CI status
All substantive checks green for 78a5fe6: validate-personas, verify-persona-teams, holdout-guard, Lint, ShellCheck, bats, unit-tests, CodeQL, agent-shield, Agent Security Scan, gitleaks, SonarCloud, actionlint, gh-aw-compile, template-drift, caller-stub-freeze all SUCCESS. Cancelled entries are superseded dev-lead/ci-relay orchestration runs ([skip ci-relay] fix commit); the one PENDING review/review check is this review itself.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1305 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
#1303 auto-merged on its 3-persona state moments before the scrum-master commit landed (the merge title even kept the old list), so scrum-master never reached main. The team
petry-projects/scrum-masteralready exists; this lands the files.Wraps the vendored bmad-method sprint-planning skill (v6.8.0) with the org wrapper
prompts/bmad/scrum-master.mdas alocal_override; advisory persona addressable as@petry-projects/scrum-master. Role, not a person (§1.6).Validated against live main (#779 + #1302 merged): 5/5 manifests valid, 9 skills / 75 eval cases.
🤖 Generated with Claude Code