Repository navigation
Adopt the persona mention router stub (next-ring activation) - #1299
Conversation
Turns on `@petry-projects/<role>` mention addressing in THIS repo (the `next`
ring — the first, smallest-blast-radius soak). Copies the caller stub from
petry-projects/.github standards/workflows/persona-mention.yml, pinned to
`persona-mention/v1-next` (the fleet copies will pin v1-stable).
This is the last link of the chain:
a comment `@petry-projects/qa-lead ...` here
→ this stub fires (issue_comment / PR review comment / discussion comment)
→ persona-mention-reusable.yml@v1-next routes it (trust floor, opt-out,
two-axis recursion guard) and dispatches `persona-mention` to this repo
→ persona-runner.yml runs qa-lead's advisory and posts one marked comment.
Everything upstream is already live on main: the router release is cut
(persona-mention/v1.0.0, v1-next → it), the runtime (#1293) is merged with its
reusable disabled_manually (still runs when called), and both org secrets exist.
Deliberately next-ring only: persona-mention is NOT in ring-pins.sh
RING_REUSABLES, so compliance does not (yet) demand this stub fleet-wide. Ring0
→ stable is a separate, gated promotion.
Kill switch: delete this file (or move persona-mention/v1-next back to a prior
tag) and mentions stop routing immediately.
Verification
- actionlint (CI ignores): clean.
- Pre-flight: persona-mention/v1-next resolves to a real
persona-mention-reusable.yml on petry-projects/.github.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
There was a problem hiding this comment.
Pull request overview
Activates the org-wide @petry-projects/<role> persona-mention routing in this repository by adding the thin caller stub workflow pinned to the persona-mention/v1-next channel (the “next” ring soak for the router).
Changes:
- Add
.github/workflows/persona-mention.ymlthin caller stub to routeissue_comment,pull_request_review_comment, anddiscussion_commentevents into the centralpersona-mention-reusable.yml. - Pin the router reusable to
petry-projects/.github/.github/workflows/persona-mention-reusable.yml@persona-mention/v1-nextand inherit org secrets for dispatch.
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: MEDIUM
Reviewed commit: ae6f1fe1a3a34b77635483d34f4a203f71b9de95
Review mode: triage-approved (single reviewer)
Summary
Adds the persona-mention thin caller stub, activating @petry-projects/ mention routing in this repo (next ring). The stub is identical to the org source of truth (standards/workflows/persona-mention.yml) except the deliberate persona-mention/v1-next pin and its explanatory comment — the canonical pin for this repo's ring tier. All upstream claims verified: the v1-next tag exists and resolves to a real persona-mention-reusable.yml; persona-mention is absent from ring-pins.sh RING_REUSABLES (so the stub is not fleet-mandated); and the release-channel-tags ruleset on petry-projects/.github restricts update/deletion on refs/tags/** — persona-mention channel tags are protected, satisfying the AGENTS.md mutable-ref exception's bounding condition.
Linked issue analysis
No linked issues (closingIssuesReferences is empty). The PR references combsmith/.github#755 (deferred reviewer-assignment trigger, tracked as finding 10) and #1293 (runtime, already merged) as context only — no issue closure is claimed, so nothing to verify against.
Findings
No blocking findings. Verification notes:
- Stub fidelity — byte-identical to
petry-projects/.githubstandards/workflows/persona-mention.ymlexcept thev1-nextchannel pin and its ring-explanation comment. Consistent with this repo being thenextring (ring_tier_for_repomaps.github-private→next). - Ref resolves —
persona-mention/v1-nexttag exists (→1dd98b7) andpersona-mention-reusable.ymlexists at that ref. - Channel-tag protection — the
release-channel-tagsruleset targetsrefs/tags/**withupdate/deletionrestricted, so the mutablev1-nexttag cannot be moved by non-bypass actors. The AGENTS.md scoped exception to SHA-pinning applies cleanly. - Permissions — workflow-level
permissions: {}with job-level read-onlyissues/pull-requests;secrets: inheritgoes only to a first-party org reusable (sanctioned pattern, NOSONAR-annotated per convention). - Not fleet-mandated —
persona-mentionis absent fromRING_REUSABLESinscripts/lib/ring-pins.sh, matching the stated scope (next ring only; ring0→stable is a separate promotion). - Secret scan — the
run_secret_scanningMCP tool was not available in this session; gitleaks CI check passed and the diff contains no secret material.
CI status
All checks green: Lint suite (actionlint, shellcheck, caller-stub-freeze, template-drift, validate-caller-inputs, validate-personas, verify-persona-teams, gh-aw-compile, bats), CI (ShellCheck, Agent Security Scan, gitleaks, Compile agentic workflows), CodeQL (actions + python), SonarCloud quality gate, AgentShield, unit-tests, Holdout Guard, Test-Deletion Guard all SUCCESS. Skipped jobs (dependabot-automerge, dependency-audit ecosystem audits, pr-review-mention) are conditional and expected to skip.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.



This is the activation. Turns on
@petry-projects/<role>mention addressing in this repo — thenextring (smallest blast radius; the fleet is not touched).Copies the caller stub from
petry-projects/.githubstandards/workflows/persona-mention.yml, pinned@persona-mention/v1-next.The full chain, now complete:
Everything upstream is already live on main: router release cut (
persona-mention/v1.0.0,v1-next→ it), runtime (#1293) merged with its reusabledisabled_manually(still runs when called), both org secrets present.Scope:
nextring only.persona-mentionis deliberately not inring-pins.shRING_REUSABLES, so compliance doesn't demand this stub fleet-wide. ring0 → stable is a separate, gated promotion.Kill switch: delete this file, or move
persona-mention/v1-nextback to a prior tag — mentions stop routing immediately.persona-mention/v1-nextpre-flight-resolves to a real reusable.🤖 Generated with Claude Code