Skip to content

Adopt the persona mention router stub (next-ring activation) - #1299

Merged
don-petry merged 1 commit into
mainfrom
feat/adopt-persona-mention-next
Jul 18, 2026
Merged

don-petry merged 1 commit into
mainfrom
feat/adopt-persona-mention-next

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

This is the activation. Turns on @petry-projects/<role> mention addressing in this repo — the next ring (smallest blast radius; the fleet is not touched).

Copies the caller stub from petry-projects/.github standards/workflows/persona-mention.yml, pinned @persona-mention/v1-next.

The full chain, now complete:

comment '@petry-projects/qa-lead ...' in this repo
  → this stub fires (issue / PR-review / discussion comment)
  → persona-mention-reusable.yml@v1-next routes it (trust floor, opt-out,
    two-axis recursion guard) → dispatches 'persona-mention' to this repo
  → persona-runner.yml runs qa-lead's advisory → posts one marked comment

Everything upstream is already live on main: router release cut (persona-mention/v1.0.0, v1-next → it), runtime (#1293) merged with its reusable disabled_manually (still runs when called), both org secrets present.

Scope: next ring only. persona-mention is deliberately not in ring-pins.sh RING_REUSABLES, so compliance doesn't demand this stub fleet-wide. ring0 → stable is a separate, gated promotion.

Kill switch: delete this file, or move persona-mention/v1-next back to a prior tag — mentions stop routing immediately.

  • actionlint clean; persona-mention/v1-next pre-flight-resolves to a real reusable.

🤖 Generated with Claude Code

Turns on `@petry-projects/<role>` mention addressing in THIS repo (the `next`
ring — the first, smallest-blast-radius soak). Copies the caller stub from
petry-projects/.github standards/workflows/persona-mention.yml, pinned to
`persona-mention/v1-next` (the fleet copies will pin v1-stable).

This is the last link of the chain:
  a comment `@petry-projects/qa-lead ...` here
    → this stub fires (issue_comment / PR review comment / discussion comment)
    → persona-mention-reusable.yml@v1-next routes it (trust floor, opt-out,
      two-axis recursion guard) and dispatches `persona-mention` to this repo
    → persona-runner.yml runs qa-lead's advisory and posts one marked comment.

Everything upstream is already live on main: the router release is cut
(persona-mention/v1.0.0, v1-next → it), the runtime (#1293) is merged with its
reusable disabled_manually (still runs when called), and both org secrets exist.

Deliberately next-ring only: persona-mention is NOT in ring-pins.sh
RING_REUSABLES, so compliance does not (yet) demand this stub fleet-wide. Ring0
→ stable is a separate, gated promotion.

Kill switch: delete this file (or move persona-mention/v1-next back to a prior
tag) and mentions stop routing immediately.

Verification
- actionlint (CI ignores): clean.
- Pre-flight: persona-mention/v1-next resolves to a real
  persona-mention-reusable.yml on petry-projects/.github.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner July 18, 2026 13:25
Copilot AI review requested due to automatic review settings July 18, 2026 13:25
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d5586366-8983-4129-834f-eaaf3c3ba754

📥 Commits

Reviewing files that changed from the base of the PR and between 4dcea31 and ae6f1fe.

📒 Files selected for processing (1)
  • .github/workflows/persona-mention.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/adopt-persona-mention-next

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 18, 2026 13:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Activates the org-wide @petry-projects/<role> persona-mention routing in this repository by adding the thin caller stub workflow pinned to the persona-mention/v1-next channel (the “next” ring soak for the router).

Changes:

  • Add .github/workflows/persona-mention.yml thin caller stub to route issue_comment, pull_request_review_comment, and discussion_comment events into the central persona-mention-reusable.yml.
  • Pin the router reusable to petry-projects/.github/.github/workflows/persona-mention-reusable.yml@persona-mention/v1-next and inherit org secrets for dispatch.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: ae6f1fe1a3a34b77635483d34f4a203f71b9de95
Review mode: triage-approved (single reviewer)

Summary

Adds the persona-mention thin caller stub, activating @petry-projects/ mention routing in this repo (next ring). The stub is identical to the org source of truth (standards/workflows/persona-mention.yml) except the deliberate persona-mention/v1-next pin and its explanatory comment — the canonical pin for this repo's ring tier. All upstream claims verified: the v1-next tag exists and resolves to a real persona-mention-reusable.yml; persona-mention is absent from ring-pins.sh RING_REUSABLES (so the stub is not fleet-mandated); and the release-channel-tags ruleset on petry-projects/.github restricts update/deletion on refs/tags/** — persona-mention channel tags are protected, satisfying the AGENTS.md mutable-ref exception's bounding condition.

Linked issue analysis

No linked issues (closingIssuesReferences is empty). The PR references combsmith/.github#755 (deferred reviewer-assignment trigger, tracked as finding 10) and #1293 (runtime, already merged) as context only — no issue closure is claimed, so nothing to verify against.

Findings

No blocking findings. Verification notes:

  1. Stub fidelity — byte-identical to petry-projects/.github standards/workflows/persona-mention.yml except the v1-next channel pin and its ring-explanation comment. Consistent with this repo being the next ring (ring_tier_for_repo maps .github-private → next).
  2. Ref resolves — persona-mention/v1-next tag exists (→ 1dd98b7) and persona-mention-reusable.yml exists at that ref.
  3. Channel-tag protection — the release-channel-tags ruleset targets refs/tags/** with update/deletion restricted, so the mutable v1-next tag cannot be moved by non-bypass actors. The AGENTS.md scoped exception to SHA-pinning applies cleanly.
  4. Permissions — workflow-level permissions: {} with job-level read-only issues/pull-requests; secrets: inherit goes only to a first-party org reusable (sanctioned pattern, NOSONAR-annotated per convention).
  5. Not fleet-mandated — persona-mention is absent from RING_REUSABLES in scripts/lib/ring-pins.sh, matching the stated scope (next ring only; ring0→stable is a separate promotion).
  6. Secret scan — the run_secret_scanning MCP tool was not available in this session; gitleaks CI check passed and the diff contains no secret material.

CI status

All checks green: Lint suite (actionlint, shellcheck, caller-stub-freeze, template-drift, validate-caller-inputs, validate-personas, verify-persona-teams, gh-aw-compile, bats), CI (ShellCheck, Agent Security Scan, gitleaks, Compile agentic workflows), CodeQL (actions + python), SonarCloud quality gate, AgentShield, unit-tests, Holdout Guard, Test-Deletion Guard all SUCCESS. Skipped jobs (dependabot-automerge, dependency-audit ecosystem audits, pr-review-mention) are conditional and expected to skip.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit e17fdca into main Jul 18, 2026
39 checks passed
@don-petry
don-petry deleted the feat/adopt-persona-mention-next branch July 18, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants