Skip to content

feat: implement issue #686 — [Phase 1] Generalize cut-release.sh + the release standard to cover non-agent reusables - #1213

Merged
don-petry merged 23 commits into
mainfrom
dev-lead/issue-686-20260714-0314
Jul 14, 2026
Merged

don-petry merged 23 commits into
mainfrom
dev-lead/issue-686-20260714-0314

Conversation

@don-petry

@don-petry don-petry commented Jul 14, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #686

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • New Features

    • Added release and channel tagging support for the ci-failure-analyst reusable workflow.
    • Standardized major-scoped channel tags across first-party reusable workflows, with support for tiers such as stable, next, and ring channels.
  • Documentation

    • Clarified immutable release tags, moving channel tags, compliance guidance, rollback targets, and cross-repository publishing conventions.
    • Updated examples and references to reflect the new tagging model.

…e release standard to cover non-agent reusables
Copilot AI review requested due to automatic review settings July 14, 2026 03:18
@don-petry
don-petry requested a review from a team as a code owner July 14, 2026 03:18
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dfd35d57-4882-42b4-af3d-82bcf01d3293

📥 Commits

Reviewing files that changed from the base of the PR and between f9c133b and 9bf5ae2.

📒 Files selected for processing (1)
  • AGENTS.md
📝 Walkthrough

Walkthrough

The release standard now covers all first-party reusable workflows, including ci-failure-analyst, with immutable release tags and major-scoped moving channel tags. Release tooling messaging and tests were updated for the new reusable.

Changes

Release channel standardization

Layer / File(s) Summary
Document unified release and channel conventions
AGENTS.md, docs/release/versioning.md
Documentation defines reusable coverage, immutable release tags, major-scoped channel tags, tier examples, pinning guidance, rollback targets, and cross-repository publishing.
Add ci-failure-analyst release references
scripts/cut-release.sh, tests/test_cut_release.bats
The release script lists ci-failure-analyst as supported, while tests verify its release and stable channel reference formats.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

Suggested labels: documentation, initiative

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: generalizing cut-release and release standards for non-agent reusables.
Linked Issues check ✅ Passed The PR adds ci-failure-analyst support and generalizes the related docs and tests as requested across the linked requirements.
Out of Scope Changes check ✅ Passed The diff stays within the release-tooling and documentation scope from the issue and adds no unrelated changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-686-20260714-0314

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extends the first-party reusable release and versioning framework to include the new ci-failure-analyst agent. It updates the documentation in AGENTS.md and docs/release/versioning.md, registers the agent in scripts/cut-release.sh, and adds corresponding unit tests in tests/test_cut_release.bats. The reviewer suggested a minor grammatical improvement in AGENTS.md to rephrase 'the this-repo reusables' to 'the reusables in this repo' for better readability.

Comment thread AGENTS.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Generalizes the existing release-tagging tooling and documentation so the same cut-release.sh + versioning standard applies beyond just dev-lead/pr-review, explicitly bringing ci-failure-analyst under the same scheme.

Changes:

  • Extend cut-release.sh’s accepted “agent” list and its usage/error strings to include ci-failure-analyst.
  • Update the Bats suite to validate ci-failure-analyst release/channel tag naming helpers.
  • Broaden the release/versioning documentation and the “mutable-ref exception” guidance in AGENTS.md to cover all first-party reusables.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
scripts/cut-release.sh Expands the accepted reusable/agent set and updates the CLI messaging to include ci-failure-analyst.
tests/test_cut_release.bats Adds coverage for ci-failure-analyst tag-name helper outputs.
docs/release/versioning.md Updates the versioning standard narrative/table to include ci-failure-analyst and position the scheme as first-party reusable-wide.
AGENTS.md Generalizes the documented mutable-ref exception to cover all first-party reusable channel tags.

Comment thread docs/release/versioning.md
Comment thread docs/release/versioning.md
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 03:35
@don-petry
don-petry disabled auto-merge July 14, 2026 03:44
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #1213
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-14T04:17:40Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-14T04:17:40Z

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 03:47
@don-petry
don-petry disabled auto-merge July 14, 2026 04:00
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — rate-limited (intent: review-changes)

PR: #1213
The retry cron will re-attempt automatically.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I received your request but all AI engines are currently rate-limited. I'll retry automatically once the rate limit clears.
Rate limit resets at: unknown

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 04:07
@don-petry
don-petry disabled auto-merge July 14, 2026 04:21
@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 04:24
@don-petry
don-petry disabled auto-merge July 14, 2026 04:25
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: None (no issues to fix)
Skipped (informational/already applied): 1
  - grammatical suggestion in AGENTS.md: already applied in PR
```
**No action required.** The PR is clean — SonarCloud passed, all CI checks passed, and no blocking reviews exist.

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 04:25
@don-petry
don-petry disabled auto-merge July 14, 2026 11:40
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #1213
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-14T12:14:44Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-14T12:14:44Z

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 11:44
@don-petry
don-petry disabled auto-merge July 14, 2026 11:48
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — rate-limited (intent: review-changes)

PR: #1213
The retry cron will re-attempt automatically.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I received your request but all AI engines are currently rate-limited. I'll retry automatically once the rate limit clears.
Rate limit resets at: unknown

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 11:57
@don-petry
don-petry disabled auto-merge July 14, 2026 17:27
@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 17:30
@don-petry
don-petry disabled auto-merge July 14, 2026 17:30
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
No action required — SonarCloud Quality Gate passed with zero findings.
```

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 17:31
@don-petry
don-petry disabled auto-merge July 14, 2026 17:47
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 17:49
@don-petry
don-petry disabled auto-merge July 14, 2026 17:50
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- Quality Gate passed with 0 new issues — no fixes needed
Files changed: none
Skipped (informational): 0
```
The PR is in good shape. SonarCloud found no actionable issues, all quality gates are green, and there are no Tier 1 blockers to resolve. No changes are needed.

@don-petry
don-petry enabled auto-merge (squash) July 14, 2026 17:50
@don-petry

Copy link
Copy Markdown
Collaborator Author

Resolving the three doc-consistency threads — the underlying concerns were addressed by later commits on this branch:

Docs are internally consistent and match the implementation. — Claude Code

@don-petry
don-petry merged commit f9f6598 into main Jul 14, 2026
32 checks passed
@don-petry
don-petry deleted the dev-lead/issue-686-20260714-0314 branch July 14, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Phase 1] Generalize cut-release.sh + the release standard to cover non-agent reusables

3 participants