Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce os.SubProcess.env DynamicVariable to override default env #295

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Introduce os.SubProcess.env DynamicVariable to override default env #295

merged 10 commits into from
Aug 30, 2024

Commits on Aug 29, 2024

  1. Introduce os.proc.env DynamicVariable to override default env 

    In Mill and any client-server application, it is handy to start processes on the server passing the
client environment. This requires to pass the environment manually in all the `os.proc(...).call()`s.
An easier alternative is to override the environment as we to for `os.Inherit` `out`, `in` and `err` pipes.
So users can forget about the environment and have the right one passed automatically.
    @lolgab
    lolgab committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    f677c90 View commit details
    Browse the repository at this point in the history

  2. Fix and ignore binary compatibility issues

    @lolgab
    lolgab committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c7dc57f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Change os.proc.env to os.SubProcess.env

    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9db0b1d View commit details
    Browse the repository at this point in the history

  2. Optimization: Avoid recreating the environment map when os.SubProcess… 

    ….env was not set
    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    75a8c51 View commit details
    Browse the repository at this point in the history

  3. Make test verify the env variable is unset

    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d07f8a4 View commit details
    Browse the repository at this point in the history

  4. Reformat

    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    da754db View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into env-dynamic-variable

    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    47cee94 View commit details
    Browse the repository at this point in the history

  6. Fix string literal for Scala 2.12

    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c8ad9e6 View commit details
    Browse the repository at this point in the history

  7. Add docs about os.SubProcess.env

    @lolgab
    lolgab committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    380c775 View commit details
    Browse the repository at this point in the history

  8. Use newer syntax in readme 

    Co-authored-by: Tobias Roeser <[email protected]>
    @lolgab @lefou
    lolgab and lefou authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    927309f View commit details
    Browse the repository at this point in the history