Fix SeqPathChunk
#160
Merged
Fix SeqPathChunk
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Mar 24, 2023
os/src/Path.scala
Outdated
Comment on lines
44
to
45
| var segments0 = Nil | ||
| var ups0 = 0 |
There was a problem hiding this comment.
Any idea, why these are here? Could you add some @deprecated on them, so we can remove them in the next major bump?
os/test/src/PathTests.scala
Outdated
Comment on lines
429
to
431
| val result = os.rel / Seq(os.up, os.rel/"hello", os.rel/"world") | ||
| val expected = os.up / "hello" / "world" | ||
| assert(result == expected) |
There was a problem hiding this comment.
Would be nice to also cover the ArrayPathChunk case here, as it's also affected by #159.
|
@lefou do you know what to do with these |
Yeah. You can run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159