Android release docs #5957
Open
Android release docs #5957
+67
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaslabs
commented
Oct 6, 2025
| def androidReleaseKeyName: Option[String] = Some("releaseKey.jks") | ||
| def androidReleaseKeyAlias: T[Option[String]] = Task { Some("releaseKey") } | ||
| def androidReleaseKeyPass: T[Option[String]] = Task { Some("MillBuildTool") } | ||
| def androidReleaseKeyStorePass: T[Option[String]] = Task { Some("MillBuildTool") } |
There was a problem hiding this comment.
Let's provide here a good default guide, perhaps with env vars
vaslabs
commented
Oct 6, 2025
| > keytool -genkey -v -keystore releaseKey.jks \ | ||
| -storepass <PASS> -keyalg RSA \ | ||
| -keysize 2048 -validity 10000 \ | ||
| -alias releaseKey -keypass <PASS> |
There was a problem hiding this comment.
"$KEYTOOL_PASS" maybe, and use the same name above like, Task.env
|
Looking at the current docs we have, I'm wondering how we can make this more user friendly. Perhaps having something like app.release.androidApk , with release being an inner trait, or app.androidReleaseApk but I think with mill's design the former could work better. Of course this is not in the scope of this PR |
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.