Use process pool for test runner (0.12.x) #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollandDM
commented
Mar 9, 2025
| @@ -161,9 +161,13 @@ object Ctx { | |||
| * terminal prompt to display what this future is currently computing. | |||
| * @param t The body of the async future | |||
| */ | |||
| def async[T](dest: os.Path, key: String, message: String)(t: => T)(implicit | |||
| def async[T](dest: os.Path, key: String, message: String, t: Logger => T)(implicit | |||
There was a problem hiding this comment.
This change is needed because scala 2.13 does not happy with (dest: os.Path, key: String, message: String(t: Logger => T) signature
HollandDM
force-pushed
the
work-stealing-test-runner-0.12.x
branch
from
a1b6967 to
2c011f5
Compare
HollandDM
force-pushed
the
work-stealing-test-runner-0.12.x
branch
from
aba1bf4 to
4aa3129
Compare
HollandDM
force-pushed
the
work-stealing-test-runner-0.12.x
branch
from
cef2744 to
95e5ff4
Compare
|
Tried this out locally, seems to speed up |
|
@lihaoyi it seems like the CI is quite flaky, could you rerun the fallen ones? |
|
Yep will do |
|
Looks good to me, the remaining flakiness is probably #4556 |
|
@HollandDM can send me your bank details to [email protected] for the bounty |
|
@lihaoyi I've update my profile to show my email, you can use that for verification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported for 0.12.x from #4614