Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly close ZincWorkerImpl classloader when worker shuts down #4332

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Properly close ZincWorkerImpl classloader when worker shuts down #4332

merged 1 commit into from
Jan 15, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 15, 2025

Previously we closed the nested classloaders, but the classloader we used to spawn ZincWorkerImpl itself was leaked

@lihaoyi lihaoyi marked this pull request as ready for review January 15, 2025 05:15
@lihaoyi lihaoyi merged commit 1384582 into com-lihaoyi:main Jan 15, 2025
35 of 37 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou