Cleanup after native image #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
lihaoyi
changed the title
| return exePath.getAbsolutePath(); | ||
| } | ||
| String javaHome = System.getProperty("java.home"); | ||
| String jvmId = "temurin:17"; |
There was a problem hiding this comment.
FYI, in Scala CLI (and also maybe in the coursier CLI), there's a check of the version of the local JVM before downloading one. If the version of the local one is high enough, it just uses it rather than downloading a new one.
lefou
reviewed
Jan 9, 2025
readme.adoc
Outdated
| ---- | ||
|
|
||
| ThYou can also use `dist.native.installLocal` for a Graal Native Image executable, |
There was a problem hiding this comment.
Suggested change
| ThYou can also use `dist.native.installLocal` for a Graal Native Image executable, | |
| You can also use `dist.native.installLocal` for a Graal Native Image executable, |
lihaoyi
commented
Jan 9, 2025
|
|
||
| def jvmIndex0(): Task[JvmIndex] = { | ||
| val coursierCache0 = FileCache[Task]() | ||
| .withLogger(coursier.cache.loggers.RefreshLogger.create()) |
There was a problem hiding this comment.
@alexarchambault for some reason this doesn't seem to be showing any progress logger on the terminal. Not sure why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.mill-jvm-version-nativeand non-nativemill executablesdist/package.milldef fixoverrides now that.fixon empty modules no longer crashes