Enable GraalVM tests on Windows #4272
Conversation
lihaoyi
added
the
run-all-tests
| val executableName = | ||
| if (mill.main.client.Util.isWindows) "native-image.exe" else "native-image" | ||
|
|
There was a problem hiding this comment.
I currently just have:
val executableName = "native-image" instead of the if check, because the Graal native-image script will automatically append an .exe extension for Windows builds.
If you don't remove the trailing .exe, the built file will have the name native-image.exe.exe leading to a file not found error in the Mill tests.
| val command = Seq.newBuilder[String] | ||
| .+=(nativeImageTool().path.toString) | ||
| .++=(nativeImageOptions()) | ||
| .+=("-cp") | ||
| .+=(nativeImageClasspath().iterator.map(_.path).mkString(java.io.File.pathSeparator)) | ||
| .+=(finalMainClass()) | ||
| .+=(executableName) | ||
| .+=((dest / executableName).toString()) | ||
| .result() | ||
| os.proc(command).call(cwd = dest, stdout = os.Inherit) | ||
| PathRef(dest / executableName) |
There was a problem hiding this comment.
I'm currently using the if-isWindows check here instead:
PathRef(dest / (if (mill.main.client.Util.isWindows) s"${executableName}.exe" else executableName))
|
|
||
| > ./out/foo/nativeImage.dest/native-image | ||
| > ./out/foo/nativeImage.dest/native-image.exe |
There was a problem hiding this comment.
> ./out/foo/nativeImage.dest/native-image without the .exe worked in my testing.
There was a problem hiding this comment.
Yeah, it seems that native-image appends the .exe automatically, but at the same time the windows terminal lets you run the file without writing out the .exe and it still works (at least until it hits the classloading issue earlier)
There was a problem hiding this comment.
I finally got it working here: https://github.com/ayewo/mill/actions/runs/12719302376/job/35459278855
I'll tidy up my changes and open a PR.
No description provided.