Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up mill process in LauncherOldVersionTests to prevent test report failures #4251

Merged
merged 8 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blog/modules/ROOT/pages/5-executable-jars.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ other build tools and toolchains will be able to provide the same convenience

// end::header[]

## Trying Out Mill's Executable Assmeblies
## Trying Out Mill's Executable Assemblies

To try out Mill's executable assembly jars, you can reproduce the above steps
with the following code and config:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ class LauncherOldVersionsTests(version: String) extends UtestIntegrationTestSuit
val res = os.call(cmd = (launcherScript, "version"), cwd = workspacePath, stderr = os.Pipe)
val outText = res.out.text().trim
assert(outText == version)
os.call(cmd = (launcherScript, "shutdown"), cwd = workspacePath, check = false)
os.remove.all(workspacePath / "out")
}
}
}
Expand Down
Loading