Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail semanticDbData if classes dir does not exist #4249

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Don't fail semanticDbData if classes dir does not exist #4249

merged 1 commit into from
Jan 5, 2025

Conversation

joan38
Copy link
Collaborator

@joan38 joan38 commented Jan 5, 2025 •
edited
Loading

This was referenced Jan 5, 2025
Closed
Closed
lefou
lefou approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lefou
Copy link
Member

lefou commented Jan 5, 2025 •
edited
Loading

Don't know about all those CI failures. Really unsatisfying but most likely unrelated. Leaving the PR to @lihaoyi for merge. Way too much flakiness, multiple restarts "fixed" CI.

@lefou lefou merged commit 8f81c0f into com-lihaoyi:main Jan 5, 2025
49 of 52 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 5, 2025
@joan38 joan38 deleted the semanticDbData branch January 5, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.6
Development

Successfully merging this pull request may close these issues.

Running "fix" on an empty module fails
2 participants
@joan38 @lefou