Sort script sources to ensure deterministic generation of child module aliases in the build.mill
/package.mill
file
#4113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seq
returned fromMillBuildRootModule#scriptSources
comes from the keys of aMap
, meaning it is arbitrary non-deterministic ordersbuild.mill
andpackage.mill
files to reference sub-folderpackage.mill
files) to occur in non-deterministic ordersTested manually, seems to remove the misbehavior reported in #4112. Managed to reproduce it in
integration/invalidation/codesig-subfolder
with some tweaks, so I left the repro in place to guard against regressionThis still leaves us open to unnecessary invalidations if someone adds a new
subfolder/package.mill
file in the middle of the list, but adding newpackage.mill
s is pretty uncommon so we can probably fix that in a follow up