Fixed: #3928 [Basic] Re-Work for First Class Python Support

[himanshumahajan138]

Pull Request

Added First Class Python Support [Basic Example]
Fixes: #3928

Description

Rework for Python 1-simple, 2-custom-build-logic and 3-multi-module Examples
follow up for PR #3992

Related Issues

• Link to related issue First Class Python Support (4000USD Bounty) #3928.

Checklist

• New Example for Python 1-Simple
• New Example for Python 2-custom-build-logic
• New Example for Python 3-multi-module
• Updated Documentation

Status

Completed Addition & Require Review!!!

[himanshumahajan138]

@lihaoyi why //// SNIPPET:DEPENDENCIES or //// SNIPPET:TREE and more like this are not working for my python docs???

i was looking in other examples but there these are available and working how ?

Please Explain about this...

[himanshumahajan138]

@lihaoyi Ready for Review!

[lihaoyi]

Took a pass at reviewing this, @jodersky should probably take a pass as well

[lihaoyi]

The issue with //// SNIPPET:DEPENDENCIES or //// SNIPPET:TREE were not working because this needs to be an ExampleCrossModuleJava which contains the template inheritance logic

mill/example/package.mill

Line 68 in b1f6be0

object basic extends Cross[ExampleCrossModule](build.listIn(millSourcePath / "basic"))

.

Let's go back to using template inheritance and seeing how much of the example docs we can share; as we proceed through the rest of the Python example docs, I expect there will be large amounts of overlap between the docs and explanations, so we should get used to using the templated documentation to begin wtih

[himanshumahajan138]

@lihaoyi @jodersky
Ready for Review
Let's wrap it up!

[himanshumahajan138]

@lihaoyi and @jodersky please take a pass and then finalize this PR as this will open the gates for all the other Python Support PR's

[lihaoyi]

I think this looks good enough for now. @himanshumahajan138 I'll merge this and close out the bounty using your existing banking details. Not perfect but we can continue to iterate on it post-merge

Going forward, I'll defer to @jodersky on how he wants to structure the work, since he's the one focusing on the Python language toolchain in Mill in the medium-long term. @himanshumahajan138 make sure to coordinate to ensure you guys don't duplicate work, since it's no longer only you working on this area of the bounties

[himanshumahajan138]

@lihaoyi Ya Sure !

I Always try to ask @jodersky Sir for conflicts and resolutions we are working in manner such that we don't face duplicate and conflicting work

Thanks for Merge...