junit5: override test discovery #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes discovery of test classes for Junit5, to be in line with that of sbt-jupiter-interface. Closes #3910
|
Looks good, but lets add at least one small unit test to reproduce the current misbehavior and assert the fix |
working on it. I guess I shouldn't tagged you on the PR before I was done ;) |
|
Haha, well the text did say "requested a review", so i reviewed it :p |
|
Sorry for the noise @lihaoyi, I'll wait before tagging you next time. I hope this is the right way to test this, let me know if there is a preferred other way. |
|
No worries! always happy to take a look. For your next PR better to open it from your own fork, that way we don't run all the jobs twice once for |
|
Looks great, thanks @jodersky ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes discovery of test classes for Junit5, to be in line with that of sbt-jupiter-interface.
Closes #3910