Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when resolve needs ModuleRef when likely cyclic references #3878

Merged
merged 18 commits into from
Nov 1, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove link from error message in ResolveCore
myyk committed Nov 1, 2024
commit a13ee360919abaeb6a37e0c9486f93fcbd9a351d
2 changes: 1 addition & 1 deletion main/resolve/src/mill/resolve/ResolveCore.scala
Original file line number Diff line number Diff line change
@@ -260,7 +260,7 @@ private object ResolveCore {
}

if (seenModules.contains(cls)) {
Left(s"Cyclic module reference detected: ${cls.getName}, it's required to wrap it in ModuleRef. See documentation: https://mill-build.org/mill/0.12.1/fundamentals/modules.html#_abstract_modules_references")
Left(s"Cyclic module reference detected: ${cls.getName}, it's required to wrap it in ModuleRef.")
} else {
val errOrIndirect0 = errOrModules match {
case Right(modules) =>