Pass BSP JvmBuildTarget stuff to ScalaBuildTarget #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Includes #3608 for now |
alexarchambault
force-pushed
the
scala-jvm-build-target
branch
from
4884a66 to
2f30bcd
Compare
Just in case, I'm not sure Metals uses that. Don't know about IntelliJ.
alexarchambault
force-pushed
the
scala-jvm-build-target
branch
from
2f30bcd to
02e4450
Compare
lihaoyi
approved these changes
Oct 8, 2024
| @@ -1056,14 +1056,15 @@ trait JavaModule | |||
| canRun = true | |||
| ) | |||
|
|
|||
| @internal | |||
| def jvmBuildTarget: JvmBuildTarget = | |||
There was a problem hiding this comment.
Should we call this bspJvmBuildTarget, just so it's clear it's related to the other bsp* members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the JVM we use in the Scala details in BSP build targets. I don't think Metals uses that for now, and I don't know about IntelliJ. But they might in the future.