Scope PromptLogger to MillBuildBootstrap#evaluate call to make prompt more intuitive
#3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, if you use
-w/--watchthe prompt starts and ends after each evaluation (which is bounded) rather than around the entire watch (which may last forever). This is much more useful so you can see where each run started and ended and how long it took, v.s. previously where it just tells you how long you've been watching for overall which is usually not something you care aboutAlso fixed a race condition where the
promptUpdaterThreadwas still running for one iteration even afterPromptLogger#close(), causing extra prompts to sometimes be displayed overlapping other logs