Introduce resolveDepsResult which returns failures correctly #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should be able to fix it by properly handling the thrown exception message without changing the API and rewriting all the callsites I think. Unless that proves to be impossible, I think that's definitely the better way to go You can take a look at it if you want, if not I'll take a look and make sure it's fixed before 0.12.0-RC1 is cut end of august |
|
So the idea is that when we get an exception during an evaluation, if it's of type |
|
Yeah, that was what I was trying to achieve in the original PR haha |
|
On it :) |
|
Implemented in #3391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.