build.mill files compiled by Scala 3 #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bishabosha ! Lets get your mainargs changes landed, that way we can cut a release and you can test your WIP in CI |
|
+1 for switching over to using directives! |
bishabosha
force-pushed
the
scala3-build-sc
branch
3 times, most recently
from
9d1a986 to
dc71022
Compare
|
[Edit: after switching to depending on mainargs 0.7.2] in https://github.com/com-lihaoyi/mill/actions/runs/10418081276/job/28853542122?pr=3369 you can see integration tests like |
lolgab
reviewed
Aug 20, 2024
bishabosha
force-pushed
the
scala3-build-sc
branch
from
729c575 to
e69f1bd
Compare
|
Rebased and included the new mill-moduledefs 0.11.0-M1 |
bishabosha
force-pushed
the
scala3-build-sc
branch
4 times, most recently
from
a06daca to
37ba541
Compare
bishabosha
force-pushed
the
scala3-build-sc
branch
5 times, most recently
from
917a024 to
78beea1
Compare
|
@lihaoyi just recording here that the mockito third party test can be flaky (specifically as seen in the CI run https://github.com/com-lihaoyi/mill/actions/runs/10909315276/job/30277476457?pr=3369#step:9:4941 |
bishabosha
force-pushed
the
scala3-build-sc
branch
9 times, most recently
from
022c789 to
368fec9
Compare
lefou
reviewed
Jan 31, 2025
| @@ -5,6 +5,7 @@ output/ | |||
| .idea_modules | |||
| .idea | |||
| .vscode/ | |||
| .zed/ | |||
There was a problem hiding this comment.
Shouldn't this be in .git/info/exclude, since it's user specific and not project specific?
gamlerhart
pushed a commit
to gamlerhart/mill
that referenced
this pull request
Feb 9, 2025
This is work in progress to fix com-lihaoyi#3152 Numerous fixes were also needed to com-lihaoyi/mainargs, com-lihaoyi/sourcecode, and com-lihaoyi/mill-moduledefs With the current state, only 1 example/integration tests is still failing: - `integration.feature[plugin-classpath].local` known TODOs: - [x] Discover macro - [x] Applicative macro - [x] Caller macro - [x] Cross.Factory macro - [x] EnclosingClass macro - [x] Task macros - [x] Cacher macro - [x] Moduledefs compiler plugin (override inferrence) - [x] All core Mill modules compile with Scala 3.5.0 - [x] Fix Zinc reporter patch linenumbers of build scripts - [x] Check that bytecode analyzers work with Scala 3 - [x] cleanup library dependency conflicts - [x] Support new Scala 3 syntax in build.sc files - [x] ~Fix BSP reporter linenumbers for build scripts~ (Zinc reporter forwards to bsp) - [ ] Cleanup compiler warnings for outdated syntax known incompatibilities: - [ ] can't use `ExplicitResultTypes` scalafix rule - need to upgrade mill-scalafix - [x] ~`Cross.scala` uses the new quoted type syntax which scalafmt crashes on, (and version is frozen) so skip the file~ upgraded Scalafmt so not skipped anymore - [ ] skipping Mima currently due to 1000s of errors (perhaps we should generate filters?) - [ ] filtered one flaky test from `example.thirdparty[mockito]` - [ ] filtered out `integration.feature[plugin-classpath]` due to third party plugin dep --------- Co-authored-by: Li Haoyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress to fix #3152
Numerous fixes were also needed to com-lihaoyi/mainargs, com-lihaoyi/sourcecode, and com-lihaoyi/mill-moduledefs
With the current state, only 1 example/integration tests is still failing:
integration.feature[plugin-classpath].localknown TODOs:
Fix BSP reporter linenumbers for build scripts(Zinc reporter forwards to bsp)known incompatibilities:
ExplicitResultTypesscalafix rule - need to upgrade mill-scalafixCross.scalauses the new quoted type syntax which scalafmt crashes on, (and version is frozen) so skip the fileexample.thirdparty[mockito]integration.feature[plugin-classpath]due to third party plugin dep