Refined mandatory ivy libs handling #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PublishModule` extends JavaModule so doesn't know about `scalaLibraryIvyDeps`. To make it insert the `scalaLibraryIvyDeps` into the pom we introduce two new targets in `JavaModule`: `mandatoryIvyDeps` which will contain libraries users unlikely will want remove, like the content of `scalaLibraryIvyDeps`, and `alIvyDeps`, which will be useful for consumers to get all the ivyDeps without missing the mandatory ones.
* Removed newly introduced `JavaModule.allIvyDeps` target * Added test case for `PublishModule.ivy` target * Some cleanups, e.g. removed obsolete overrides in ScalaModule * Some ScalaDoc
lolgab
approved these changes
Sep 23, 2021
lolgab
reviewed
Sep 23, 2021
lefou
force-pushed
the
scala-library-in-ivy-deps-3
branch
from
1d887ac
to
cffeafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
JavaModule.mandatoryIvyDepstarget to contain typical required ivy dependencies without the need to override and includesuper.ivyDeps.This fixes #1487 and streamlines platform dependency handling for downstream modules like
ScalaModule,ScalaJSModule,ScalaNativeModule. It's probably also useful for other modules which need to bring-in additional dependencies.This PR includes and refines PR #1489.