Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy lints, fix deprecation warnings #179

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

atezet
Copy link
Contributor

@atezet atezet commented Oct 10, 2024

Went ahead and fixed some clippy lints and deprecation warnings. Might break backwards compatibility, so maybe merge this before bumping the version to 3.0

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing anything that would be breaking, so it should be good.

@spenserblack
Copy link
Collaborator

@atezet All of the changes in cee0316 were generated with cargo clippy --fix, right?

@spenserblack
Copy link
Collaborator

Oops, only squash and rebase merging are enabled in this repo, so I can't add 4744838 to this PR. Nevermind.

@spenserblack spenserblack merged commit 05b0f57 into colored-rs:master Oct 10, 2024
28 checks passed
@atezet
Copy link
Contributor Author

atezet commented Oct 10, 2024

I've added some pedantic rules that I use across my projects. The following are configured in my editor:

clippy::cloned_instead_of_copied
clippy::expl_impl_clone_on_copy
clippy::explicit_deref_method
clippy::needless_pass_by_value
clippy::no_effect_underscore_binding
clippy::redundant_allocation
clippy::semicolon_if_nothing_returned
clippy::trivially_copy_pass_by_ref
clippy::unnecessary_wraps
clippy::unused_async
clippy::unused_self
clippy::wildcard_imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants