Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arbitrary ANSI color #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for arbitrary ANSI color #166

wants to merge 1 commit into from

Conversation

Asthowen
Copy link

Add ansi_color and on_ansi_color on Colorize trait.

kurtlawrence
kurtlawrence requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@kurtlawrence kurtlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry under breaking changes

@kurtlawrence kurtlawrence changed the base branch from master to v3 February 26, 2024 23:06
@kurtlawrence kurtlawrence added the breaking Will need a major version bump label Feb 26, 2024
@spenserblack
Copy link
Collaborator

Oops, sorry, my attention has been on more recently active PRs. The master branch is now on v3, so could you target that for your PR and make any necessary changes (the changelog, for example)?

@Asthowen Asthowen changed the base branch from v3 to master January 14, 2025 18:01
@Asthowen
Copy link
Author

It's done 👍.

spenserblack
spenserblack approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Asthowen Asthowen requested a review from spenserblack February 1, 2025 23:08
@cnlancehu cnlancehu mentioned this pull request Feb 18, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtlawrence kurtlawrence kurtlawrence approved these changes

@spenserblack spenserblack Awaiting requested review from spenserblack

Assignees
No one assigned
Labels
breaking Will need a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asthowen @spenserblack @kurtlawrence